Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix musl build. #793

Closed
wants to merge 3 commits into from
Closed

Attempt to fix musl build. #793

wants to merge 3 commits into from

Conversation

clarfonthey
Copy link
Contributor

Follow-up to #685 and #700.

@alexcrichton
Copy link
Member

Thanks! Looks good to me, but CI is failing?

@clarfonthey
Copy link
Contributor Author

Fixed the style errors; waiting for Travis again.

@clarfonthey
Copy link
Contributor Author

It appears to be passing!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 9, 2017

📌 Commit 59904c6 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 9, 2017

⌛ Testing commit 59904c6 with merge 334abbc...

bors added a commit that referenced this pull request Oct 9, 2017
Attempt to fix musl build.

Follow-up to #685 and #700.
@alexcrichton
Copy link
Member

@bors: r- retry

er actually, can you verify this works in the rustc repo?

@bors
Copy link
Contributor

bors commented Oct 9, 2017

☀️ Test successful - status-appveyor, status-travis
State: approved= try=False

clarfonthey added a commit to clarfonthey/rust that referenced this pull request Oct 16, 2017
@clarfonthey
Copy link
Contributor Author

I made a PR for the rustc repo to test it out; I think that's how this is supposed to work?

@clarfonthey
Copy link
Contributor Author

@alexcrichton it seems to work in the PR I made, so, I think this is okay to merge?

@alexcrichton
Copy link
Member

Er what I mean is to actually test this. For example actually build libstd for these targets and make sure it works.

One error, for example, is that stdbuild is no longer a thing. For example this PR as-is should break linkage on all these targets.

@bors
Copy link
Contributor

bors commented Oct 28, 2017

☔ The latest upstream changes (presumably #824) made this pull request unmergeable. Please resolve the merge conflicts.

@marioidival
Copy link
Member

@clarcharr you can fix the conflict?
@alexcrichton after conflict, need more changes here?

@alexcrichton
Copy link
Member

Ah I think I'll close for inactivity for now, but this'll just need to be tested against rust-lang/rust before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants