-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix musl build. #793
Conversation
Thanks! Looks good to me, but CI is failing? |
Fixed the style errors; waiting for Travis again. |
It appears to be passing! |
@bors: r+ |
📌 Commit 59904c6 has been approved by |
@bors: r- retry er actually, can you verify this works in the rustc repo? |
☀️ Test successful - status-appveyor, status-travis |
I made a PR for the rustc repo to test it out; I think that's how this is supposed to work? |
@alexcrichton it seems to work in the PR I made, so, I think this is okay to merge? |
Er what I mean is to actually test this. For example actually build libstd for these targets and make sure it works. One error, for example, is that |
☔ The latest upstream changes (presumably #824) made this pull request unmergeable. Please resolve the merge conflicts. |
@clarcharr you can fix the conflict? |
Ah I think I'll close for inactivity for now, but this'll just need to be tested against rust-lang/rust before merging. |
Follow-up to #685 and #700.