Fixes and test for x86_64-unknown-linux-gnux32 #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malbarbo
commented
Oct 27, 2017
| pub u_ar0: *mut user_regs_struct, | ||
| #[cfg(target_pointer_width = "32")] | ||
| __pad2: u32, |
There was a problem hiding this comment.
Considering the definition of the user struct, it's seems odd to add a pad before the field, but without it, the test fails...
| - cargo build | ||
| - cargo build --no-default-features | ||
| - cargo build $OPT | ||
| - cargo build $OPT --no-default-features |
There was a problem hiding this comment.
I think this may not be necessary due to the clause in run.sh below?
| @@ -68,4 +68,10 @@ if [ "$QEMU" != "" ]; then | |||
| exec grep "^PASSED .* tests" $CARGO_TARGET_DIR/out.log | |||
| fi | |||
|
|
|||
| exec cargo test --manifest-path libc-test/Cargo.toml --target $TARGET | |||
| # FIXME: x86_64-unknown-linux-gnux32 fail to compile wihout --release | |||
There was a problem hiding this comment.
Perhaps an issue could be filed to tag here as well?
|
Nice! Everything looks great here modulo one nit for the issue to tag, and otherwise r=me |
|
@bors: r+ |
|
📌 Commit e63f46a has been approved by |
bors
added a commit
that referenced
this pull request
Oct 27, 2017
Fixes and test for x86_64-unknown-linux-gnux32 This fixes all libc tests and almost all rustc tests (3 libstd tests and one run-pass test fails). Fixes #816
|
💔 Test failed - status-travis |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Oct 28, 2017
Fixes and test for x86_64-unknown-linux-gnux32 This fixes all libc tests and almost all rustc tests (3 libstd tests and one run-pass test fails). Fixes #816
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all libc tests and almost all rustc tests (3 libstd tests and one run-pass test fails).
Fixes #816