Skip to content

Add net interface device flag #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

LuoZijun
Copy link
Contributor

@LuoZijun LuoZijun commented Nov 7, 2017

Add net interface device flag for all platforms.

@alexcrichton
Copy link
Member

Thanks! Looks like some CI is failing though? Also, could the formatting changes be left to a separate commit or a separate PR?

@LuoZijun
Copy link
Contributor Author

LuoZijun commented Nov 8, 2017

@Alexander255
the failing is about libc/ci/style.rs

like some lines longer than 80 chars, maybe we should turn off panic and use one rustfmt.toml ?

@ntninja
Copy link
Contributor

ntninja commented Nov 8, 2017

@LuoZijun I take it you were talking to @alexcrichton, not me? 🙂

@LuoZijun
Copy link
Contributor Author

LuoZijun commented Nov 8, 2017

@Alexander255 Oh ... my mistake :D

i'm talking about @alexcrichton :)

@alexcrichton
Copy link
Member

@LuoZijun for now let's stick with style.rs, it in theory shouldn't be too too hard to adhere to. Eventually we can use rustfmt when it's ready

bors added a commit that referenced this pull request Nov 9, 2017
Add network interface flag constants for all platforms

Add network interface flag constants for all platforms.

old PR: #839
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants