Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network interface flag constants for all platforms #840

Merged
merged 5 commits into from
Nov 9, 2017

Conversation

LuoZijun
Copy link
Contributor

@LuoZijun LuoZijun commented Nov 8, 2017

Add network interface flag constants for all platforms.

old PR: #839

@alexcrichton
Copy link
Member

Thanks! Loks like there's some CI errors though?

@LuoZijun
Copy link
Contributor Author

LuoZijun commented Nov 9, 2017

@alexcrichton this error from libc/ci/style.rs , the master branch can not be pass too, not only my patch-1 branch.

@faern
Copy link
Contributor

faern commented Nov 9, 2017

@LuoZijun What if you remove all the formatting and make the PR contain only the new constants? Try that. Even if it does not make the tests pass more it at least makes the PR focused more on the feature, and not on formatting.

EDIT: As you can see the master branch does build: https://travis-ci.org/rust-lang/libc/builds/298203207
Might be that you have a different version/setup of some software that makes it fail when you build locally?

@LuoZijun
Copy link
Contributor Author

LuoZijun commented Nov 9, 2017

@faern

i'm sry, i found that problem is my sublime setting ( "format_on_save": true ).

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 9, 2017

📌 Commit 165bbc3 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 9, 2017

⌛ Testing commit 165bbc3 with merge ecc3e01...

bors added a commit that referenced this pull request Nov 9, 2017
Add network interface flag constants for all platforms

Add network interface flag constants for all platforms.

old PR: #839
@bors
Copy link
Contributor

bors commented Nov 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ecc3e01 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants