Handle new self-profiling information for incr-comp hash fingerprints #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michaelwoerister
left a comment
michaelwoerister
left a comment
There was a problem hiding this comment.
I left a comment on how to timing adjustments for the new event.
3 tasks
Member
Author
|
This should be ready, but leaving it as a draft since it relies on the changes to rustc landing first. |
Member
|
I think this is ready to be merged, right? There is no harm in being able to handle the new events before those events actually get generated. Correct me if I'm wrong, @rylev r? @wesleywiser |
Member
Author
|
This is ready to review. I marked it as work-in-progress, because I wasn’t sure if the support in rustc needed to land first. Either way that support is being merged, so it’s fine to mark this as ready to review. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 22, 2021
…ywiser Profile incremental compilation hashing fingerprints Adds profiling instrumentation for the hashing of incremental compilation fingerprints per query. This will eventually feed into the `measureme` and `rustc-perf` infrastructure for tracking if computing hashes changes over time. TODOs: * [x] Address the FIXME where we are including node interning in the hash timing. * [ ] Update measureme/summarize to handle this new data: rust-lang/measureme#166 * [ ] ~Update rustc-perf to handle the new data from measureme~ (will be done at a later time) r? `@ghost` cc `@michaelwoerister`
wesleywiser
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on changes in rust-lang/rust#86619 where you can read a bit more about the goals of this change.
Putting into draft mode until rust-lang/rust#86619 is more fully discussed.