-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile incremental compilation hashing fingerprints #86619
Conversation
7fc5ba6
to
1dae419
Compare
This comment has been minimized.
This comment has been minimized.
1dae419
to
6e33dce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments below.
r? @wesleywiser |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b5bec17 with merge c9fc2e1e84356aa00676a311f656a51d6f8abdc0... |
☀️ Try build successful - checks-actions |
Queued c9fc2e1e84356aa00676a311f656a51d6f8abdc0 with parent 5c0ca08, future comparison URL. |
Finished benchmarking try commit (c9fc2e1e84356aa00676a311f656a51d6f8abdc0): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and will be quite useful as well! Thanks 🙂
@bors r+ |
📌 Commit b5bec17 has been approved by |
⌛ Testing commit b5bec17 with merge e41ba3635dd798f0aeccae91b2d19f372e0f85ec... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Looks like a spurious error during LLVM build. Let's give it another try. @bors retry |
☀️ Test successful - checks-actions |
Adds profiling instrumentation for the hashing of incremental compilation fingerprints per query.
This will eventually feed into the
measureme
andrustc-perf
infrastructure for tracking if computing hashes changes over time.TODOs:
Update rustc-perf to handle the new data from measureme(will be done at a later time)r? @ghost
cc @michaelwoerister