Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile incremental compilation hashing fingerprints #86619

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Jun 25, 2021

Adds profiling instrumentation for the hashing of incremental compilation fingerprints per query.

This will eventually feed into the measureme and rustc-perf infrastructure for tracking if computing hashes changes over time.

TODOs:

r? @ghost

cc @michaelwoerister

@rylev rylev marked this pull request as draft June 25, 2021 12:27
@rylev rylev force-pushed the incr-hashing-profiling branch from 7fc5ba6 to 1dae419 Compare July 2, 2021 16:06
@rust-log-analyzer

This comment has been minimized.

@rylev rylev force-pushed the incr-hashing-profiling branch from 1dae419 to 6e33dce Compare July 7, 2021 08:44
Copy link
Member

@michaelwoerister michaelwoerister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments below.

@rylev rylev marked this pull request as ready for review July 7, 2021 09:17
@rylev
Copy link
Member Author

rylev commented Jul 7, 2021

r? @wesleywiser

@wesleywiser
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2021
@bors
Copy link
Collaborator

bors commented Jul 20, 2021

⌛ Trying commit b5bec17 with merge c9fc2e1e84356aa00676a311f656a51d6f8abdc0...

@bors
Copy link
Collaborator

bors commented Jul 20, 2021

☀️ Try build successful - checks-actions
Build commit: c9fc2e1e84356aa00676a311f656a51d6f8abdc0 (c9fc2e1e84356aa00676a311f656a51d6f8abdc0)

@rust-timer
Copy link
Collaborator

Queued c9fc2e1e84356aa00676a311f656a51d6f8abdc0 with parent 5c0ca08, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (c9fc2e1e84356aa00676a311f656a51d6f8abdc0): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 20, 2021
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and will be quite useful as well! Thanks 🙂

@wesleywiser
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 21, 2021

📌 Commit b5bec17 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2021
@bors
Copy link
Collaborator

bors commented Jul 21, 2021

⌛ Testing commit b5bec17 with merge e41ba3635dd798f0aeccae91b2d19f372e0f85ec...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
      Memory: 14 GB
      Boot ROM Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMqUj3dBSPC6

hw.ncpu: 3
hw.byteorder: 1234
+ ./x.py --stage 2 test
---
[ 26%] Building X86GenCallingConv.inc...
[ 26%] Building X86GenDAGISel.inc...
[ 26%] Building CXX object tools/llvm-cxxmap/CMakeFiles/llvm-cxxmap.dir/llvm-cxxmap.cpp.o
error: Connection to server timed out
make[2]: *** [tools/llvm-cxxmap/CMakeFiles/llvm-cxxmap.dir/llvm-cxxmap.cpp.o] Error 2
make[1]: *** [tools/llvm-cxxmap/CMakeFiles/llvm-cxxmap.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 26%] Building X86GenDisassemblerTables.inc...
[ 26%] Building RISCVGenSearchableTables.inc...
[ 26%] Building X86GenEVEX2VEXTables.inc...
[ 26%] Building RISCVGenSubtargetInfo.inc...
---
[ 27%] Building X86GenRegisterBank.inc...
[ 27%] Building X86GenRegisterInfo.inc...
[ 27%] Building X86GenSubtargetInfo.inc...
[ 27%] Built target X86CommonTableGen
make: *** [all] Error 2
command did not execute successfully, got: exit status: 2
 finished in 2929.849 seconds

Build completed unsuccessfully in 1:48:21
Build completed unsuccessfully in 1:48:21
build script failed, must exit now', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.44/src/lib.rs:885:5

@bors
Copy link
Collaborator

bors commented Jul 21, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2021
@michaelwoerister
Copy link
Member

error: Connection to server timed out

Looks like a spurious error during LLVM build. Let's give it another try.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2021
@michaelwoerister michaelwoerister added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Jul 22, 2021
@bors
Copy link
Collaborator

bors commented Jul 22, 2021

⌛ Testing commit b5bec17 with merge f913a4f...

@bors
Copy link
Collaborator

bors commented Jul 22, 2021

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing f913a4f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2021
@bors bors merged commit f913a4f into rust-lang:master Jul 22, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants