-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-miri version information is outdated #3845
Comments
Why not? The commit is in the rustc repo, which contains Miri, so it says exactly the commit you have to look at to find out which version of Miri rustup installed.
That's not quite right. There's no separate rustc binary we are forwarding this to. Miri is a rustc driver and so this shows the version of the rustc driver Miri is using. |
That's unfortunately not true if you build miri yourself, is it? |
Ah, yeah. But that's going to be a dev version anyway so the version should probably just say "dev" or so, similar to what local rustc builds do.
|
Also note that |
Yes.. for me that prints
Which is interesting, but I can not even find the commit (or whatever it is) referenced there. In general, what repository do they belong to? Also, the last change I made to the miri installation I ran this command in was today. So again, there's no way of getting the miri version. |
Generally, development versions don't have a version. That's deliberate, and consistent with rustc.
If you installed via |
bump rustc_tools_util version Fixes rust-lang/miri#3845 by incorporating rust-lang/rust-clippy#13329
Would it be possible to add version information to miri? Currently, running
miri --version
forwards this flag torustc
, so it prints e.g.which is not useful.
Instead, it would be nice to have
miri --version
and maybe evencargo miri version
. My personal use-case is that I want to double-check that I am using the correctmiri
when I am making modifications to it to debug/test some other code somewhere else.The text was updated successfully, but these errors were encountered: