-
Notifications
You must be signed in to change notification settings - Fork 1.6k
rustc_tools_util: rerun when git commit changes #13329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
4e2c942
to
67fd516
Compare
ec77894
to
c96586d
Compare
@Alexendoo it's been a month -- any feedback on this PR? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait, having to rebuild on each commit/checkout is unfortunate but at least it's only the top level package and not clippy_utils
/clippy_lints
35ae117
to
6b8c6f6
Compare
Thanks! @flip1995 what's the process for getting a new release out for |
I can create a release after this is merged. @RalfJung Can you bump the version of |
Eh, that makes some tests fail? Is that expected? Seems quite painful if tests need to be adjusted for each version bump of this crate... |
Hm, it tests itself, by running the macro on itself. Bumping the 3 versions in the tests fixes the test breakage. It's unfortunate, but as we're not updating this very often, I think this is fine. |
I just realized that also a changelog is missing. I'll update all of this and push it to this PR, if you don't mind? |
93137fb
to
7ce5ff4
Compare
I have tried to fix the test. But yeah could be good if you could write the changelog. :) |
7ce5ff4
to
4daf918
Compare
4daf918
to
65fdfb8
Compare
Pushed the changelog update and rebased on top of master. |
@bors r=Alexendoo,flip1995 p=10 |
Published the new version and also bumped it in Clippy itself. Let's get this merged ASAP. cc @dtolnay |
rustc_tools_util: rerun when git commit changes Fixes #13312
💔 Test failed - checks-action_test |
@bors retry (missing changelog) |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bump rustc_tools_util version Fixes #3845 by incorporating rust-lang/rust-clippy#13329
bump rustc_tools_util version Fixes rust-lang/miri#3845 by incorporating rust-lang/rust-clippy#13329
Fixes #13312
changelog: none