Use .wasm extension when building for wasm in cargo-miri
#2685
Conversation
|
Thanks! We should also test this. Usually we just add new targets in |
Noratrieb
force-pushed
the
cargo-miri-wasm
branch
2 times, most recently
from
26dc948 to
8e21633
Compare
ci.sh
Outdated
| @@ -85,7 +85,7 @@ case $HOST_TARGET in | |||
| MIRI_TEST_TARGET=i686-pc-windows-msvc run_tests | |||
| MIRI_TEST_TARGET=x86_64-unknown-freebsd run_tests_minimal hello integer vec panic/panic concurrency/simple atomic data_race env/var | |||
| MIRI_TEST_TARGET=aarch64-linux-android run_tests_minimal hello integer vec panic/panic | |||
| MIRI_TEST_TARGET=wasm32-wasi run_tests | |||
| MIRI_TEST_TARGET=wasm32-wasi MIRI_NO_STD=1 run_tests_minimal # supports std but miri doesn't support it | |||
There was a problem hiding this comment.
run_tests_minimal expects as argument a filter to indicate which tests should be run. No filter means all tests.
However, run_tests_minimal also does not test cargo miri, so... it's not really helpful for this PR.
|
Supporting wasi will take a while, that needs a bunch of wasi APIs to be implemented in Miri. We should probably find a way to land this without doing that. I would suggest a 2-step process:
|
RalfJung
added
the
S-waiting-on-author
…o-miri-actually-works-kinda, r=RalfJung Test a small cargo-miri smoke test even in `run_tests_minimal` This makes sure that cargo-miri works on all targets. Implements the first step of #2685 (comment) to get that PR tested.
|
#2690 landed, so hopefully we can test cargo-miri on wasm in that way. :) A rebase should show whether that works. |
WASM uses the `.wasm` file extension for its binaries (just like how windows uses `.exe`), so we need to set that as well.
Noratrieb
force-pushed
the
cargo-miri-wasm
branch
from
8e21633 to
66a88c2
Compare
|
It works, CI passed! |
|
The bad news is that the smoke test isn't actually testing what it claims to test... see #2701. |
|
All right, let's see if they still pass. |
|
☀️ Test successful - checks-actions |
…that-cargo-miri-actually-works-kinda, r=RalfJung Test a small cargo-miri smoke test even in `run_tests_minimal` This makes sure that cargo-miri works on all targets. Implements the first step of rust-lang/miri#2685 (comment) to get that PR tested.
WASM uses the
.wasmfile extension for its binaries (just like how windows uses.exe), so we need to set that as well.I'm not sure whether gating this behind the wasm target is a good idea, maybe it makes more sense to always do it just like on windows.