-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test a small cargo-miri smoke test even in run_tests_minimal
#2690
Test a small cargo-miri smoke test even in run_tests_minimal
#2690
Conversation
libtest needs |
Yeah that's why I suggested a 'cargo run' smoketest, not 'cargo test'.
Or is that still too platform-specific?
|
Getting a |
This is Miri, no linking should be required... We successfully do run https://github.com/rust-lang/miri/blob/master/tests/pass/no_std.rs on no_std targets in our test suite. Does that not also work with |
Oh yes, this is Miri, I forgot about that :D The example you have looks good, I think I can use that. |
This makes sure that cargo-miri works on all targets.
d7ace28
to
ae96d6a
Compare
test-cargo-miri/Cargo.lock
Outdated
@@ -81,6 +81,10 @@ version = "0.1.0" | |||
name = "issue_rust_86261" | |||
version = "0.1.0" | |||
|
|||
[[package]] | |||
name = "no-std-smoke" | |||
version = "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is excluded, why is it listed in the lockfile...?
@bors r+ |
☀️ Test successful - checks-actions |
This makes sure that cargo-miri works on all targets.
Implements the first step of #2685 (comment) to get that PR tested.