Rustup #445
Merged
Rustup #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to make the pointer equality a bit smarter: When comparing a really big integer with a pointer that cannot possibly be so big or else the allocation would wrap around the end of the address space, we also say these are inequal. This is needed for |
oli-obk
reviewed
Aug 30, 2018
src/operator.rs
Outdated
| // Compute the highest address at which this allocation could live | ||
| let alloc = self.memory.get(ptr.alloc_id)?; | ||
| let max_base_addr = | ||
| (1u128 << self.pointer_size().bits()) - alloc.bytes.len() as u128; |
There was a problem hiding this comment.
for alignment > 1 this could be even more permissive, right?
oli-obk
reviewed
Aug 30, 2018
src/operator.rs
Outdated
| // The integer is too big, this cannot possibly be equal | ||
| false | ||
| } else { | ||
| // TODO: We could also take alignment into account |
There was a problem hiding this comment.
oh, you already added a todo, ignore my above comment
|
Since you clearly took a look and had no reservations, I assume I can merge once CI is green? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for rust-lang/rust#53779
Functional changes: