-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustup #445
Merged
Rustup #445
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
904923f
move some more helpers to rustc
RalfJung e239fcf
new tests for new fn arg passing code
RalfJung c442679
ptr equality: only defined for ptrs in the same allocation and live ptrs
RalfJung 2a31826
also allow comparing pointers with integers so big that they cannot b…
RalfJung 74c6a1a
bump toolchain
RalfJung 1697b93
Merge branch 'master' into rustup
RalfJung d3928f6
more permissive pointer comparison logic
RalfJung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,11 +148,30 @@ impl<'a, 'mir, 'tcx> EvalContextExt<'tcx> for EvalContext<'a, 'mir, 'tcx, super: | |
left == right | ||
} | ||
} | ||
// Comparing ptr and integer -- we only allow compating with NULL | ||
(Scalar::Ptr(_), Scalar::Bits { bits: 0, .. }) | | ||
(Scalar::Bits { bits: 0, .. }, Scalar::Ptr(_)) => false, | ||
// Nothing else is supported | ||
_ => return err!(InvalidPointerMath), | ||
// Comparing ptr and integer -- we allow compating with NULL, and with addresses | ||
// so close to the end of the `usize` range that they cannot overlap with an allocation | ||
// of the given size. | ||
(Scalar::Ptr(ptr), Scalar::Bits { bits, size }) | | ||
(Scalar::Bits { bits, size }, Scalar::Ptr(ptr)) => { | ||
assert_eq!(size as u64, self.pointer_size().bytes()); | ||
if bits == 0 { | ||
// Nothing equals 0 | ||
false | ||
} else { | ||
// Compute the highest address at which this allocation could live | ||
let alloc = self.memory.get(ptr.alloc_id)?; | ||
let max_base_addr = | ||
(1u128 << self.pointer_size().bits()) - alloc.bytes.len() as u128; | ||
let max_addr = max_base_addr + ptr.offset.bytes() as u128; | ||
if bits > max_addr { | ||
// The integer is too big, this cannot possibly be equal | ||
false | ||
} else { | ||
// TODO: We could also take alignment into account | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh, you already added a todo, ignore my above comment |
||
return err!(InvalidPointerMath); | ||
} | ||
} | ||
} | ||
}) | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for alignment > 1 this could be even more permissive, right?