Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup #445

Merged
merged 7 commits into from
Sep 1, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions src/operator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,30 @@ impl<'a, 'mir, 'tcx> EvalContextExt<'tcx> for EvalContext<'a, 'mir, 'tcx, super:
left == right
}
}
// Comparing ptr and integer -- we only allow compating with NULL
(Scalar::Ptr(_), Scalar::Bits { bits: 0, .. }) |
(Scalar::Bits { bits: 0, .. }, Scalar::Ptr(_)) => false,
// Nothing else is supported
_ => return err!(InvalidPointerMath),
// Comparing ptr and integer -- we allow compating with NULL, and with addresses
// so close to the end of the `usize` range that they cannot overlap with an allocation
// of the given size.
(Scalar::Ptr(ptr), Scalar::Bits { bits, size }) |
(Scalar::Bits { bits, size }, Scalar::Ptr(ptr)) => {
assert_eq!(size as u64, self.pointer_size().bytes());
if bits == 0 {
// Nothing equals 0
false
} else {
// Compute the highest address at which this allocation could live
let alloc = self.memory.get(ptr.alloc_id)?;
let max_base_addr =
(1u128 << self.pointer_size().bits()) - alloc.bytes.len() as u128;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for alignment > 1 this could be even more permissive, right?

let max_addr = max_base_addr + ptr.offset.bytes() as u128;
if bits > max_addr {
// The integer is too big, this cannot possibly be equal
false
} else {
// TODO: We could also take alignment into account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, you already added a todo, ignore my above comment

return err!(InvalidPointerMath);
}
}
}
})
}

Expand Down