Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document internal unsafety #182

Closed
wants to merge 2 commits into from
Closed

Document internal unsafety #182

wants to merge 2 commits into from

Conversation

calebzulawski
Copy link
Member

Fixes #173.

I found an ICE in clippy along the way, so we shouldn't actually merge this until rust-lang/rust-clippy#7945 is upstream.

Copy link
Member

@programmerjake programmerjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@calebzulawski
Copy link
Member Author

I think we're going to have to put this off a bit more--clippy doesn't seem to recognize safety comments inside macros any longer (and of course nearly everything is in macros for now)

@calebzulawski calebzulawski deleted the feature/safety branch October 17, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document internal unsafety
3 participants