rebase "Add some safety comments" #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
force-pushed
the
partial-safety
branch
2 times, most recently
from
1dea939
to
c017b47
Compare
|
Caleb is going to follow up on this so closing. |
workingjubilee
force-pushed
the
partial-safety
branch
from
c017b47
to
18de6c4
Compare
|
This wound up falling behind again so reopening and rebasing, dropping dated remarks. This keeps not making it in due to changes, but I would rather have half of it than none of it, so I am going to merge this in unless @calebzulawski strenuously objects. |
|
Yep, might as well merge it. |
|
If you want, later today I can rebase the entire original branch, though, since I think this is only a small portion of the original comments. |
|
A lot of the ones I dropped need to just be rewritten, so you're welcome to take a swing at that but I don't think it's actually worth thrashing git for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial rebase of #182, I just wanted to see if this passes CI now.