-
Notifications
You must be signed in to change notification settings - Fork 340
Update website for rustup installation #621
Conversation
I like this overall! Some thoughts:
|
@brson Thanks for this! It looks great by and large, just a few nits. Front pageI'd suggest changing the text of the button on the front page to say "Install", at the same font size as the version number, and drop the "Current release" (which is implied). At any rate, I think mentioning "install" or "download" somewhere on the button is important, to make clear what the action of the button is. Otherwise, 👍 Install pageThis is the page that needs the most work, I think. Here are some thoughts:
Other installation methodsThis page feels a lot better than in the earlier draft -- cohesive and clean. Just a few notes:
|
This should go live ASAP. It's fine for the book to lag the "official" change IMO, since rustup.rs has been the de facto way to install Rust for quite a while nowl |
@steveklabnik thanks for reviewing.
I agree. I'll take another pass at it.
OK. I will add it.
Oh, I was thinking of landing it as soon as possible. I hadn't thought about the stable book not being in agreement with the website. I also have not prepared any changes to the book for this, at least not yet. |
I sent in a PR for the book, you're the reviewer IIRC. I would be okay with landing this before the book, getting people on rustup ASAP is more important than consistency. Maybe we can be a bit more okay with changing the book earlier in cases like these in the future, though 😄 |
OK I've updated based on all suggestions.
Some outstanding concerns of mine
Remember you can type "test" to see the platform-specific instructions. |
Oh @aturon re headers on the install page. The reason for both having gray headers and not the top-level header was that I thought they were distracting the eye from the big box of instructions. In the new revision the big "Install Rust" header still feels pretty obstructive and noisy to me, but it's not awful. |
Another concern. The install page still mentions the |
A few thoughts:
|
In powershell, the % syntax does not work. Instead you have to do either |
Another thing to point out, the msvc version of Rust currently is built against VS 2013. So if the user gets the VC++ 2015 build tools, that will provide the 2015 redistributables, but not the 2013 redistributables so they'll need to be installed separately for rustc/cargo to even run. A few people have run into this issue, so it's not just hypothetical. If we took advantage of the static CRT feature that was implemented recently, then this would no longer be a concern. https://www.microsoft.com/en-us/download/details.aspx?id=40784 |
@brson The updates look great! My only nit is on the install page -- can we avoid the horizontal rule after the Install Rust header? Given that the rustup directions are in their own box, the extra rule is adding extra clutter, I think. Otherwise, LGTM! |
I actually changed it in this pr from "Download" to "Install" thinking that "Install" was more correct. If e.g. this page was titled "Download Rust" it would seem kinda wrong to me. Why is "Download" easier to parse than "Install"?
This is kind of troubling. It seems to me that it's not a lot worse than today where if they pick the (recommended) MSVC build they will run into the same problem. I don't think there's anything blocking us from static linking our msvc builds now so hopefully we can resolve that soon. |
Rebased. The only thing I changed this round was removing the the horizontal rule from the install page but @aturon I think it looks poor, the "Install Rust" looks out of place to me. I have not changed "Install" to "Download" because I'm not convinced of it yet. |
By parse I mean visually parse. In general, I suspect the word "Download" will catch your eye faster than "Install". YMMV. |
The look without the hr is growing on me, but I still think it doesn't look great. |
@brson I think it's good enough to ship. We can keep playing with these fine details over time. |
I think I'm going to change the "Install" page back to "Downloads" after all, the deciding factor being that the front page has both "Install" and "Install Rust 1.13.0" links in big letters. Having the menu say "Downloads" instead will make the button the obvious choice. I think the title of the actual page still has to be "Install Rust" since it makes more sense than "Download Rust" considering the page's content. So the "Download" menu item will go to the "install.html", "Install Rust" page. Wierd. |
Argh, I can't decide. |
Just updating the structure, using english content. Needs to be retranslated.
OK, I still have it as "Install" for now. I've updated all the translations to use the new content from the english pages. cc @aka-demik @3442853561 @thebergamo @KineticCookie @Calinou @lazpeng past translators there's a lot of content changing here soon. |
Looks fantastic. Let's land this thing! |
🎊 |
\o/ |
Update book for rustup Supersedes #37934 Don't land yet. Needs coordination with rust-lang/prev.rust-lang.org#621 Fixes #35653 r? @steveklabnik
This patch makes rustup the default Rust installer. The main changes are in these pages.
This is still rough, but is content complete, so I'm posting it to start collecting feedback.
Some of the ideas here:
On the install page you can type "test" to cycle through platform-specific stuff.
The early feedback I've gotten felt like the info here was overwhelming. So there's probably some streamlining to do. In particular, most of the content of the install page could be cut or bumped to the other-installers page.
Some caveats to be aware of during this transition:
The two pieces of information that I felt compelled to surface on the install page - that rustup is a tool you need to know about, and that the PATH needs to be configured correctly - are unfortunate. I'd prefer if we could not explain anything. The reason you need to know about the rustup command is because it's used for uninstallation, and I consider it important that we explain how to uninstall.
Today, on Windows, rustup will detect whether MSVC is available during install, and if so, use the MSVC toolchain, otherwise use GNU. I found explaining this to be too hard, and intend to make rustup just use the MSVC toolchain period, and offer guidance on how to install MSVC or change to GNU.
In review, I'd focus on the content for now more than the code. Once it's close to ready there will be more to clean up and delete, and I'll need to figure out how to deal with the translations.
r? @steveklabnik cc @aturon