-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Book: rustup.sh -> rustup.rs #37934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book: rustup.sh -> rustup.rs #37934
Conversation
@steveklabnik: no appropriate reviewer found, use r? to override |
This only covers installing rustup from a bash terminal. It doesn't cover installing rustup from either powershell or cmd. Granted, cmd doesn't really have a way to download files, but powershell totally does: |
@retep998 do you have the time to give me some phrasing of how you'd like it to appear? My only experience has been with bash. also, cc @carols10cents on this, as we should sync that with the new book too |
cc @brson |
@steveklabnik The new book is already using rustup.rs. For windows, I just said "go to rustup.rs and follow the instructions". |
Yeah, I was thinking of the Windows changes that happen. |
Might it be better to actually include less information in the book and basically just link to https://www.rust-lang.org/install.html so there is a single source of truth? |
@ollie27 This text is included in the offline documentation, and the website isn't. So I still like having it in the book. Most books have text in them about installing things, even if there's a site. |
read it offline. On UNIX systems, `/usr/local/share/doc/rust` is the location. | ||
On Windows, it's in a `share/doc` directory, inside the directory to which Rust | ||
was installed. | ||
read it offline. It's only a `rustup doc` away! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if that behavior actually survives; seems fairly controversial.
Looks good. I agree it should say something about windows. One option is telling them to navigate to It might also be worthwhile to present the download link directly in the text. I guess for now I'd suggest keeping the two sections, one for Linux/Mac and one for Windows. In the windows section link directly to I do think a link to install.html is warranted still since there's more to learn there. "For other installation options, see the install page on the Rust website". etc. I'll also try to get a powershell one-liner working. If we had that we might present the curl instructions, the powershell instructions, and then "for other installation methods see the website". |
Closing in favor of #38122 |
Update book for rustup Supersedes #37934 Don't land yet. Needs coordination with rust-lang/prev.rust-lang.org#621 Fixes #35653 r? @steveklabnik
Fixes #35653
cc rust-lang/prev.rust-lang.org#621