Skip to content

Book: rustup.sh -> rustup.rs #37934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Book: rustup.sh -> rustup.rs #37934

wants to merge 1 commit into from

Conversation

steveklabnik
Copy link
Member

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jonhoo Jon Gjengset
@rust-highfive
Copy link
Contributor

@steveklabnik: no appropriate reviewer found, use r? to override

@retep998
Copy link
Member

This only covers installing rustup from a bash terminal. It doesn't cover installing rustup from either powershell or cmd. Granted, cmd doesn't really have a way to download files, but powershell totally does: Invoke-WebRequest. At the very least there should still be a section describing how to download and install the rustup.rs installer on Windows.

@steveklabnik
Copy link
Member Author

steveklabnik commented Nov 22, 2016

@retep998 do you have the time to give me some phrasing of how you'd like it to appear? My only experience has been with bash.

also, cc @carols10cents on this, as we should sync that with the new book too

@retep998
Copy link
Member

cc @brson

@carols10cents
Copy link
Member

carols10cents commented Nov 22, 2016

@steveklabnik The new book is already using rustup.rs. For windows, I just said "go to rustup.rs and follow the instructions".

@steveklabnik
Copy link
Member Author

Yeah, I was thinking of the Windows changes that happen.

@ollie27
Copy link
Member

ollie27 commented Nov 23, 2016

Might it be better to actually include less information in the book and basically just link to https://www.rust-lang.org/install.html so there is a single source of truth?

@steveklabnik
Copy link
Member Author

@ollie27 This text is included in the offline documentation, and the website isn't. So I still like having it in the book. Most books have text in them about installing things, even if there's a site.

read it offline. On UNIX systems, `/usr/local/share/doc/rust` is the location.
On Windows, it's in a `share/doc` directory, inside the directory to which Rust
was installed.
read it offline. It's only a `rustup doc` away!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if that behavior actually survives; seems fairly controversial.

@brson
Copy link
Contributor

brson commented Nov 29, 2016

Looks good.

I agree it should say something about windows.

One option is telling them to navigate to https://www.rust-lang.org/install.html is probably best. You might present it like "Installing Rust is really simple. The instructions are on the Rust website (link), but if you are on Linux and Mac you can just type:"

It might also be worthwhile to present the download link directly in the text.

I guess for now I'd suggest keeping the two sections, one for Linux/Mac and one for Windows. In the windows section link directly to htts://win.rustup.rs saying like "On Windows download and run rustup-init.exe", linking to it.

I do think a link to install.html is warranted still since there's more to learn there. "For other installation options, see the install page on the Rust website". etc.

I'll also try to get a powershell one-liner working. If we had that we might present the curl instructions, the powershell instructions, and then "for other installation methods see the website".

@brson brson mentioned this pull request Dec 2, 2016
@brson
Copy link
Contributor

brson commented Dec 2, 2016

Closing in favor of #38122

@brson brson closed this Dec 2, 2016
bors added a commit that referenced this pull request Dec 17, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jonhoo Jon Gjengset
Update book for rustup

Supersedes #37934

Don't land yet. Needs coordination with rust-lang/prev.rust-lang.org#621

Fixes #35653

r? @steveklabnik
@alexcrichton alexcrichton deleted the gh35653 branch December 29, 2016 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants