Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII chars in identifiers aren't supported yet #111

Merged
merged 2 commits into from
Oct 13, 2017

Conversation

brauliobz
Copy link
Contributor

It's misleading to keep XID_Start and XID_Continue on the reference, since they may never be supported in stable.

@steveklabnik
Copy link
Member

steveklabnik commented Sep 5, 2017

They are still part of Rust, just behind a flag. The reference currently does document unstable things as well. We haven't quite figured out the way we want to handle this kind of thing, generally.


[keywords]: keywords.html

[^non_ascii_idents] Non-ASCII characters in identifiers are currently feature-gated. See [issue #28979](https://github.com/rust-lang/rust/issues/28979).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd snip everything below this. You can move the comment into the Unstable Book, or it's in the git history. This also involves removing the link from the text above.

@brauliobz brauliobz force-pushed the grammar_identifiers branch from b7ea86c to 0e4342e Compare October 13, 2017 02:17
@brauliobz
Copy link
Contributor Author

The corresponding Unstable Book PR.

@Havvy Havvy merged commit 7bfc70e into rust-lang:master Oct 13, 2017
@Havvy
Copy link
Contributor

Havvy commented Oct 13, 2017

💟 Thanks.

@brauliobz brauliobz deleted the grammar_identifiers branch October 13, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants