Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved details of unstable non-ascii identifiers from the Reference #45250

Merged
merged 2 commits into from
Oct 15, 2017
Merged

Moved details of unstable non-ascii identifiers from the Reference #45250

merged 2 commits into from
Oct 15, 2017

Conversation

brauliobz
Copy link
Contributor

Moved details of unstable non-ascii identifiers from the Reference to the Unstable book

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brauliobz brauliobz mentioned this pull request Oct 13, 2017
Merged
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2017
steveklabnik
steveklabnik suggested changes Oct 13, 2017
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but

[01:27:20] unstable-book/print.html:1496: broken link - unstable-book/keywords.html

[01:27:20] unstable-book/language-features/non-ascii-idents.html:123: broken link - unstable-book/keywords.html

you'll need to change the link to something like ../../reference/keywords.html#strict-keywords

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2017
@kennytm
Copy link
Member

kennytm commented Oct 14, 2017

CI passed, assuming good to go.

@bors r=steveklabnik rollup

@bors
Copy link
Contributor

bors commented Oct 14, 2017

📌 Commit 8e6119f has been approved by steveklabnik

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 14, 2017
@kennytm
Rollup merge of rust-lang#45250 - brauliobz:non-ascii-idents-details,…
0f806dd 
… r=steveklabnik

Moved details of unstable non-ascii identifiers from the Reference

Moved details of unstable non-ascii identifiers from the Reference to the Unstable book

r? @steveklabnik
@kennytm kennytm mentioned this pull request Oct 14, 2017
Closed
bors added a commit that referenced this pull request Oct 14, 2017
@bors
Auto merge of #45291 - kennytm:rollup, r=kennytm
24834ee 
Rollup of 9 pull requests

- Successful merges: #45113, #45250, #45255, #45258, #45263, #45264, #45269, #45280, #45289
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Oct 15, 2017
@kennytm
Rollup merge of rust-lang#45250 - brauliobz:non-ascii-idents-details,…
b6f4cea 
… r=steveklabnik

Moved details of unstable non-ascii identifiers from the Reference

Moved details of unstable non-ascii identifiers from the Reference to the Unstable book

r? @steveklabnik
@kennytm kennytm mentioned this pull request Oct 15, 2017
Merged
bors added a commit that referenced this pull request Oct 15, 2017
@bors
Auto merge of #45299 - kennytm:rollup, r=kennytm
8382f39 
Rollup of 9 pull requests

- Successful merges: #45113, #45250, #45255, #45258, #45263, #45264, #45269, #45280, #45289
- Failed merges:
@bors bors merged commit 8e6119f into rust-lang:master Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik requested changes

Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brauliobz @rust-highfive @kennytm @bors @steveklabnik