Outdated ticky box lists

[aturon]

My personal checklist is pretty outdated. For example:

• Tracking issue for '_ rust#48469 is checked off and closed
• Standard library API for immovable types rfcs#2349 (comment) is checked off and closed
• RFC: Quick dbg!(expr) macro rfcs#2173 (comment) same

and so on

[Centril]

Hmm... Could you provide a bit more detail about what's wrong?
Not sure what needs to be fixed at the moment.

[anp]

@Centril IIRC @aturon was talking about the list at https://rfcbot.rs/fcp/aturon. It is indeed quite long, I believe longer than the number of current FCPs even.

[Centril]

Oh weird; they don't show up on https://rfcbot.rs/ tho. I'll investigate soon-ish :)

[anp]

This issue is here I think: https://github.com/anp/rfcbot-rs/blob/master/src/nag.rs#L77-L80. When the consensus metric changed from "all team members have reviewed" to "most team members have reviewed" that query would no longer function. Once an FCP finishes, you'd still be a reviewer who had not read it, but I don't think checking the boxes would ever update the database (who needs to update the state of things that are fully finished?).

[anp]

So I think the solution would be to modify that query to only include FCPs that are pending or active.

[Centril]

@anp yeah; that sounds accurate.