Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #212 by filtering in RFCs not yet in FCP #223

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fix #212 by filtering in RFCs not yet in FCP #223

merged 1 commit into from
Jun 21, 2018

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jun 21, 2018

Fixes #212.

@Centril Centril requested a review from anp June 21, 2018 10:54
anp
anp approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@anp anp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So exciting! When I first wrote this code Diesel barely had join support IIRC 😅 so that's a nice optimization.

@Centril
Copy link
Contributor Author

Centril commented Jun 21, 2018

=)

Should probably move to a post-1.0 version of diesel at some point to get more goodies ;)

@Centril Centril merged commit 2c4ad48 into rust-lang:master Jun 21, 2018
@Centril Centril deleted the fix/212 branch June 21, 2018 17:58
anoadragon453 pushed a commit to matrix-org/mscbot that referenced this pull request Jul 6, 2018
@Centril
fix rust-lang#212 by filtering in unstarted fcps. (rust-lang#223)
efd1761 
Former-commit-id: 2c4ad48
Centril added a commit to Centril/rfcbot-rs that referenced this pull request Aug 11, 2018
@Centril
fix rust-lang#212 by filtering in unstarted fcps. (rust-lang#223)
0de4780
Centril added a commit that referenced this pull request Aug 16, 2018
@Centril
[Needs review] Feature: @rfcbot poll [teams] (#219)
ce8e298 
* add itertools as dependency.

* add database model for Poll stuff.

* really add itertools as dependency in main.rs.

* teams: expose test data, change team names a bit, expose ping and name of teams.

* refactor a bunch of logic and implement polling (hopefully...).

* update command grammar in README.md.

* fix syntax error in up.sql migration.

* fix copy error in up.sql migration.

* fix typo in up.sql migration.

* close poll when everyone has answered it.

* fix #212 by filtering in unstarted fcps. (#223)

* Update toolchain and lockfile (#232)

* update toolchain and lockfile.

* add never_type gate.

* Add Centril to the lang team (#230)

* fix typos (quized -> quizzed).

* fix 225, and deal with leading whitespace.

* colocate from_invocation_line and from_str_all.

* get rid of global state from command parser.

* review -> response for polls.

* fix comments.

* make progress on all 3 in evaluate_nags.

* RfcBotCommand::{AskQuestion -> StartPoll}.

* gracefully handle poll comment typos.

* fix bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anp anp anp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Centril @anp