Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC acceptance process: we should hyperlink issue/PR numbers #133

Closed
lilyball opened this issue Jun 23, 2014 · 2 comments
Closed

RFC acceptance process: we should hyperlink issue/PR numbers #133

lilyball opened this issue Jun 23, 2014 · 2 comments

Comments

@lilyball
Copy link
Contributor

When an RFC is accepted, it is modified to include the PR number and the issue number for the tracking issue on rust-lang/rust. Since RFCs are markdown rather than plain text, these two numbers should be hyperlinked to the actual PR/issue they refer to.

For example, when RFC 18 was accepted (in b683d2e), it was modified like so:

-- RFC PR #:
-- Rust Issue #:
+- RFC PR #: 79
+- Rust Issue #: 14309

This should instead have been:

-- RFC PR #:
-- Rust Issue #:
+- RFC PR #: [79](https://github.com/rust-lang/rfcs/pull/79)
+- Rust Issue #: [14309](https://github.com/rust-lang/rust/issues/14309)
@chris-morgan
Copy link
Member

Duplicate of #62.

@lilyball
Copy link
Contributor Author

You're right.

wycats added a commit to wycats/rust-rfcs that referenced this issue Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants