Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the RFC header to improve the PR/issue links #62

Closed
chris-morgan opened this issue May 1, 2014 · 1 comment · Fixed by #188
Closed

Change the RFC header to improve the PR/issue links #62

chris-morgan opened this issue May 1, 2014 · 1 comment · Fixed by #188

Comments

@chris-morgan
Copy link
Member

(a) At present, the format of the RFC header (excluding the start date line which is fine) is like this:

- RFC PR #: 19
- Rust Issue #: 13231
  • RFC PR #: 19
  • Rust Issue #: 13231

(b) Given that we are using GitHub, this would be more immediately useful like this:

- RFC PR: #19
- Rust Issue: mozilla/rust#13231

(c) For optimal clarity and portability across GitHub, we could extend the RFC PR to be an absolute reference:

- RFC PR: rust-lang/rfcs#19
- Rust Issue: mozilla/rust#13231

(d) For absolute portability, we could use URLs:

- RFC PR: https://github.com/rust-lang/rfcs/pull/19
- Rust Issue: https://github.com/mozilla/rust/issue/13231

(e) Possibly with friendly labels (mix this with the first three options to produce (e.a), (e.b) and (e.c); below, (e.c) is shown):

- RFC PR: [rust-lang/rfcs#19](https://github.com/rust-lang/rfcs/pull/19)
- Rust Issue: [mozilla/rust#13231](https://github.com/mozilla/rust/issue/13231)

I suggest (c) or (e.c).

@lilyball
Copy link
Contributor

👍

chris-morgan added a commit to chris-morgan/rfcs that referenced this issue Jul 29, 2014
Fixes rust-lang#62. Of the formats proposed there, I went with option (e.c).
chris-morgan added a commit to chris-morgan/rfcs that referenced this issue Jul 30, 2014
Fixes rust-lang#62. Of the formats proposed there, I went with option (e.c).
glaebhoerl pushed a commit to glaebhoerl/rfcs that referenced this issue Aug 8, 2014
Fixes rust-lang#62. Of the formats proposed there, I went with option (e.c).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants