Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC for providing ignore test message #3217

Closed
wants to merge 3 commits into from

Conversation

yanganto
Copy link

@yanganto yanganto commented Jan 7, 2022

This RFC proposes to add ignore message into the summary as a result of cargo test.

running 2 tests
test tests::test_ignored ... ignored, not yet implemented
test tests::test_works ... ok
test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s

Rendered

Previous discussion on IRLO

@ehuss
Copy link
Contributor

ehuss commented Jan 8, 2022

FWIW, I don't feel like this really needs an RFC. This is just a presentation issue, which can be changed at any time. I think just opening a PR to change it would be sufficient. However, I'm not on the libs team, so they may feel differently. You can try asking on Zulip (#t-libs).

@nikomatsakis
Copy link
Contributor

I agree with @ehuss that this doesn't require an RFC, but I also think this would be a great addition!

@yanganto
Copy link
Author

Thanks, I try to work on the PR.
There are some test cases that fail and I still have no idea how to fix them.
I am really appreciated that if someone is willing to help with this.
Thanks.

@nrc nrc added the T-dev-tools Relevant to the development tools team, which will review and decide on the RFC. label Jan 10, 2022
@yanganto yanganto closed this Jan 14, 2022
@yanganto
Copy link
Author

Hi @nrc, I find that there is a not-rfc tag, but you did not tag not-rfc for this. Should I keep this PR or not? I am a little confused about this, by the way, there already is a PR for this, may you kindly take a look at that also, and help me to figure out how to make this thing happen. Thanks.

@kennytm
Copy link
Member

kennytm commented Jan 26, 2022

@yanganto not-rfc is used for non proposal PRs like typo fixes. That label does not apply to this PR.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2022
…ulacrum

Provide ignore message in the result of test

Provide ignore the message in the result of the test.

This PR does not need RFC, because it is about the presentation of the report of `cargo test`.

However, the following document listed here helps you to know about PR.

- [RFC](rust-lang/rfcs#3217)
- [Rendered](https://github.com/yanganto/rfcs/blob/ignore-test-message/text/0000-ignore-test-message.md)
- [Previous discussion on IRLO](https://internals.rust-lang.org/t/pre-rfc-provide-ignore-message-when-the-test-ignored/15904)

If there is something improper, please let me know.
Thanks.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 25, 2022
…ulacrum

Provide ignore message in the result of test

Provide ignore the message in the result of the test.

This PR does not need RFC, because it is about the presentation of the report of `cargo test`.

However, the following document listed here helps you to know about PR.

- [RFC](rust-lang/rfcs#3217)
- [Rendered](https://github.com/yanganto/rfcs/blob/ignore-test-message/text/0000-ignore-test-message.md)
- [Previous discussion on IRLO](https://internals.rust-lang.org/t/pre-rfc-provide-ignore-message-when-the-test-ignored/15904)

If there is something improper, please let me know.
Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-dev-tools Relevant to the development tools team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants