Provide ignore message in the result of test

[yanganto]

Provide ignore the message in the result of the test.

This PR does not need RFC, because it is about the presentation of the report of cargo test.

However, the following document listed here helps you to know about PR.

• RFC
• Rendered
• Previous discussion on IRLO

If there is something improper, please let me know.
Thanks.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

[ehuss]

I think it is tricky to change the definition of TestDesc because we want to be able to run the standard library tests with the beta compiler (which won't have the changes to TestDesc). The proc-macro expansion of the #[test] attribute generated by the beta compiler will have TestDesc without the new field, but it is being built with the new definition.

I think you will need to annotate the field (and everywhere it is used) with #[cfg(not(bootstrap))]. The bootstrap cfg is only set when building with the beta compiler. This will likely be very tricky, so I'm glossing over the details, but hopefully that can set you in the right direction.

[yanganto]

Hi @matthiaskrgr,
I hope the merge(679f4dd) will not mess up the rollup process, I uncarefully clicked the fetch-upstream button from the GitHub web page. And this PR was collected in #94120. If there is something I can do to fix this, please let me know thanks.

[yanganto]

Hi @Mark-Simulacrum @matthiaskrgr, I hope this PR is good for rolling up, if there is something can do from my side please let me know. Thanks. 🙏

[yanganto]

@bors retry

[bors]

@yanganto: 🔑 Insufficient privileges: not in try users

[Mark-Simulacrum]

We typically avoid merge commits, instead preferring to rebase -- I've done so now, @bors r+

[bors]

📌 Commit bb3b557 has been approved by Mark-Simulacrum

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 4b043faba34ccc053a4d0110634c323f6c03765e and 847a02cb48a90efa909d0511ed1cd978ca0e3d2d
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
thread '[compile-fail] compile-fail/validity/invalid_fnptr_uninit.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.7.1/src/runtest.rs:1092:13
stack backtrace:
thread '[compile-fail] compile-fail/validity/fn_ptr_offset.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.7.1/src/runtest.rs:1092:13
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/compile-fail/validity/invalid_fnptr_uninit.rs" "-L" "/tmp/compiletestfTVevb" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletestfTVevb/validity/invalid_fnptr_uninit.stage-id" "-A" "unused" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-L" "/tmp/compiletestfTVevb/validity/invalid_fnptr_uninit.stage-id.aux"
    Error {
        line_num: 9,
        kind: Some(
            Error,
---
stack backtrace:
   0: std::panicking::begin_panic::<&str>
   1: <compiletest_rs::runtest::TestCx>::run_cfail_test
   2: compiletest_rs::runtest::run
   3: <compiletest_rs::make_test_closure::{closurethread '#[compile-fail] compile-fail/validity/execute_memory.rs0}' panicked at ' as explicit paniccore', ::/cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.7.1/src/runtest.rsops:::1092function:::13FnOnce
    },
]

not found errors (from test file): [
---
error: tests/compile-fail/validity/fn_ptr_offset.rs:9: expected error not found: expected a function pointer

error: 1 unexpected errors found, 1 expected errors not found
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/compile-fail/validity/fn_ptr_offset.rs" "-L" "/tmp/compiletestfTVevb" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletestfTVevb/validity/fn_ptr_offset.stage-id" "-A" "unused" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-L" "/tmp/compiletestfTVevb/validity/fn_ptr_offset.stage-id.aux"
    Error {
        line_num: 9,
        kind: Some(
            Error,
---
error: tests/compile-fail/validity/execute_memory.rs:6: expected error not found: expected a function pointer

error: 0 unexpected errors found, 1 expected errors not found
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/compile-fail/validity/execute_memory.rs" "-L" "/tmp/compiletestfTVevb" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletestfTVevb/validity/execute_memory.stage-id" "-A" "unused" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-L" "/tmp/compiletestfTVevb/validity/execute_memory.stage-id.aux"
    Error {
        line_num: 6,
        kind: Some(
            Error,
---
.......... (50/60)
.......... (60/60)


/checkout/src/test/rustdoc-gui/search-result-go-to-first.goml An exception occured: Failed to launch the browser process!
Inconsistency detected by ld.so: dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!


TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md
== STACKTRACE ==
Error
Error
    at innerRunTestCode (/node-v14.4.0-linux-x64/lib/node_modules/browser-ui-test/src/index.js:468:16)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

[Mark-Simulacrum]

Seems likely to be a spurious failure.

[yanganto]

@Mark-Simulacrum Thanks for your help on this. 😄

[m-ou-se]

This seems to have modified the output of --logfile rather than the output to the console. Was that intentional?

Is there a test for the expected output?

[Mark-Simulacrum]

Hm, no, that was not intentional (I had not realized we even had a logfile?).

[yanganto]

@m-ou-se Thanks for this, I am fixing this. 😅