We've reached semi-official status, we need a status bar

[matklad]

VS Code provides API for a status bar:

https://code.visualstudio.com/api/references/vscode-api#StatusBarItem

we should implement status bar for rust-analyzer, for the following purposes:

• clearly indicating when rust-anlayzer is enabled
• clearly indicating when rust-analyzer needs a reload. Our current strategy of showing a notification on every keypress in the config is pretty obnoxious, we really should just change the color of the status bar
• indicate the "loading" state of rust-analyzer (?)
• indicate presence of updates for nightly (?)
• provide one-click troubleshooting options (?)

[matklad]

cc @Veetaha this seems like something you might be interested in, as it touches on many systems you've helped to improve already!

[Veetaha]

Not sure how the status bar pertains to yesterday's RFC, but I'll try to take a look into this task anyway

[Veetaha]

@matklad what do you mean by a notification on every keypress? This shouldn't happen on each keypress, if it does then this is a bug, but it does clearly work as intended for me now, i.e. you get the notification when the config value is modified once and never thereafter until you touch it again

[Veetaha]

Besides that, I am used to having a blue color of the status bar and orange when in debugging mode, I am not sure we should abuse this power to add new states to the status bar

[Veetaha]

3d we do indicate the loading of packages as a progress notification, could you elaborate on this item more?

[Veetaha]

5th which troubleshooting options are you implying? Please elaborate...

[eminence]

RA already uses the status bar in some places. Just to be clear if we're talking about the same thing... When first loading a workspace, the initial analysis status is shown:

And if running cargo-check-on-save is enabled, a StatusBarItem is shown also:

Is the proposal to have a new permanent StatusBarItem that is always visible? (Similar to the github status bar item, which is always visible when I've opened a project that's hosted on github)

[matklad]

what do you mean by a notification on every keypress?

[Veetaha]

@matklad Do you have files.autoSave, enabled?

[matklad]

Ah, that explains it! Still, the fundamental issue remains that "you need to relaoad" is a status, and not an event.

…

On Thu, 23 Apr 2020 at 16:19, Veetaha ***@***.***> wrote: @matklad <https://github.com/matklad> Do you have files.autoSave, enabled? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4074 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANB3M23ZYRQ4ATBY6EKIGTROBE7FANCNFSM4MNML5IQ> .

[Veetaha]

@matklad, could you elaborate on this and this

[eminence]

Here's another use-case for a status bar -- after RA has loaded, it does a prime_caches step. This can take a while, and until this is done, semantic highlighting will be missing. Yet there's no hint (other than high cpu usage) that RA is doing anything. So a notification in the status bar would be useful here!

[bjorn3]

What is missing after #5188?

[matklad]

Nothing, the "one step troubleshooting" unforunately has to go, as status bar icons don't support context menu