Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StatusBar #5188

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Implement StatusBar #5188

merged 2 commits into from
Jul 2, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 2, 2020

No description provided.

@fannheyward fannheyward mentioned this pull request Jul 2, 2020
Open
@matklad matklad force-pushed the status branch 3 times, most recently from 34e1937 to 7a5954e Compare July 2, 2020 13:15
@kjeremy
Copy link
Contributor

kjeremy commented Jul 2, 2020

Could we use window/showMessage instead and capture it on the ts side for custom display?

@matklad
Copy link
Member Author

matklad commented Jul 2, 2020

I guess this would technically work, but that would mean that we will be spamming the user with notifications, and I'd rather avoid that.

@kjeremy
Copy link
Contributor

kjeremy commented Jul 2, 2020 •
edited
Loading

Makes sense. I wonder if we should propose that a "persistent notification" be added to the protocol.

@matklad
Copy link
Member Author

matklad commented Jul 2, 2020

There's some discussion about this over there: microsoft/language-server-protocol#511 (comment)

@matklad
Copy link
Member Author

matklad commented Jul 2, 2020

bors r+

bors bot added a commit that referenced this pull request Jul 2, 2020
@bors @matklad
Merge #5188
b7f3720 
5188: Implement StatusBar r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@matklad matklad mentioned this pull request Jul 2, 2020
Open
@bors
Copy link
Contributor

bors bot commented Jul 2, 2020

Build failed:

@matklad
Copy link
Member Author

matklad commented Jul 2, 2020

Hm?

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 2, 2020

Build succeeded:

@bors bors bot merged commit 1a3a7f4 into rust-lang:master Jul 2, 2020
@matklad matklad deleted the status branch July 2, 2020 14:10
@bjorn3 bjorn3 mentioned this pull request Jul 2, 2020
Closed
@prabirshrestha prabirshrestha mentioned this pull request Dec 23, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @kjeremy