Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Bump a couple of deps #14593

Merged
merged 7 commits into from
Apr 17, 2023
Merged

minor: Bump a couple of deps #14593

merged 7 commits into from
Apr 17, 2023

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Apr 17, 2023

Only a couple because I didn't yet try to untangle the windows-sys / syn 2.0.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2023
@lnicola lnicola changed the title Bump a couple of deps minor: Bump a couple of deps Apr 17, 2023
@lnicola
Copy link
Member Author

lnicola commented Apr 17, 2023

TBH, it feels like we should accept the duplicate dependencies and maybe file PRs to the other projects to upgrade, instead of trying to avoid them. But yeah, syn and maybe windows-sys are probably heavier than most.

@Veykril
Copy link
Member

Veykril commented Apr 17, 2023

I wanted to give the ecosystem a bit of time to update to syn2, that was the main reason for pinning. Though I really don't want syn to be duplicated, it is already way too heavy as is 😩

@lnicola
Copy link
Member Author

lnicola commented Apr 17, 2023

I might do another pass in the next couple of days. This pulls in a second bitflags (but it builds in like 200 ms), but it will probably take a while for most crates to upgrade. With syn I think we're blocked on tracing-attributes (already merged, not released), arbitrary (same, but maybe less active), and maybe chalk.

@lnicola
Copy link
Member Author

lnicola commented Apr 17, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2023

📌 Commit 160ab88 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 17, 2023

⌛ Testing commit 160ab88 with merge 1f92641...

@bors
Copy link
Contributor

bors commented Apr 17, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 1f92641 to master...

@bors bors merged commit 1f92641 into rust-lang:master Apr 17, 2023
@lnicola lnicola deleted the bump-deps branch April 17, 2023 16:31
@davidbarsky
Copy link
Contributor

With syn I think we're blocked on tracing-attributes (already merged, not released)

I'll try to get a release out this week.

@Veykril
Copy link
Member

Veykril commented Apr 17, 2023

Chalk also upgraded already

@lnicola
Copy link
Member Author

lnicola commented Apr 17, 2023

No worries, salsa will take much longer to upgrade.

@lnicola
Copy link
Member Author

lnicola commented Apr 17, 2023

Yeah, but it's still pulling in both: rust-lang/chalk#793 (comment). Bad wording on my side, sorry.

@Veykril
Copy link
Member

Veykril commented Apr 17, 2023

Oh no, salsa depends on it as well right... That's a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants