vscode: askBeforeDownload option #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 7, 2020 23:59
Also renamed BinarySource to ArtifactSource in anticipation of nightlies installation that requires downloading not a binary itself but .vsix package, thus generalized to `artifact` term
The new name seems much simpler and it doesn't limit this config value only to downloading the server binary. Thus we wouldn't need to create another config properties to handle other downloads whatsoever. Anyway, I believe (heuristically) that most of the users would want to set "askBeforeDownload": false once and never bother clicking on the notification again (because otherwise there is no big point in installing rust-analyzer if it cannot install the server)
Veetaha
changed the title
Veetaha
force-pushed
the
feature/vscode-impl-nightlies
branch
from
621d045
to
28c6412
Compare
Veetaha
force-pushed
the
feature/vscode-impl-nightlies
branch
from
28c6412
to
2847636
Compare
matklad
reviewed
Mar 9, 2020
editors/code/package.json
Outdated
| @@ -219,6 +219,11 @@ | |||
| } | |||
| } | |||
| }, | |||
| "rust-analyzer.askBeforeDownload": { | |||
There was a problem hiding this comment.
Let's group this into rust-analyzer.updates, as we might want to add .chanel soon as well? We should refactor old options to use the same grouping at some point, but it makes sense to design new options with more up-front planing that we use to have.
|
bors r+ |
Build succeeded |
bors
added a commit
that referenced
this pull request
Jun 20, 2024
CI: run benches with hyperfine rather than bash The hyperfine installation is cached so this should not cost a lot of CI time. This is step 1/2 to getting rid of the BASH variable hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small step towards #3402, also implements my proposal stated in #3403
Also renamed
BinarySourcetoArtifactSourcein anticipation of nightlies installation that requires downloading not a binary itself but.vsixpackage, thus generalized toartifactterm.@matklad @lnicola