Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: askBeforeDownload option #3514

Merged
merged 7 commits into from
Mar 9, 2020

Commits on Mar 7, 2020

  1. Configuration menu
    Copy the full SHA
    9dae94a View commit details
    Browse the repository at this point in the history
  2. vscode: care about alwaysDownloadServer option before asking

    Also renamed BinarySource to ArtifactSource in anticipation of
    nightlies installation that requires downloading
    not a binary itself but .vsix package, thus generalized
    to `artifact` term
    Veetaha committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    c29a502 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. vscode: add docs on alwaysDownloadServer

    Veetaha committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    49b4e88 View commit details
    Browse the repository at this point in the history
  2. vscode: rename alwaysDownloadServer -> askBeforeDownload

    The new name seems much simpler and it doesn't limit
    this config value only to downloading the server binary.
    Thus we wouldn't need to create another config
    properties to handle other downloads whatsoever.
    Anyway, I believe (heuristically) that most of the users
    would want to set "askBeforeDownload": false once
    and never bother clicking on the notification again
    (because otherwise there is no big point in installing rust-analyzer if it cannot install the server)
    Veetaha committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    6bd1ff1 View commit details
    Browse the repository at this point in the history
  3. docs: change formatting

    Veetaha committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    2847636 View commit details
    Browse the repository at this point in the history
  4. vscode: fix inversion of askBeforeDownload

    Veetaha committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    de99fa7 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Configuration menu
    Copy the full SHA
    ce65cc9 View commit details
    Browse the repository at this point in the history