New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how CLI args are applied to `Builder` #2984

Open

pvdrz wants to merge 2 commits into main from pvdrz/refactor-cli-arg-application

+295 −487

Contributor

pvdrz commented Nov 20, 2024

These changes abstract away the most commonly used patterns to apply CLI args to the Builder:

if bool_cli_arg {
    builder = builder.method(bool_cli_arg);
}

if let Some(value) = option_cli_arg {
    builder = builder.method(value);
}

for value in vec_cli_arg {
    builder = builder.method(value);
}


          delete duplicated default logic for --anon-fields-prefix

41fc8bf

pvdrz force-pushed the pvdrz/refactor-cli-arg-application branch 2 times, most recently from 126f869 to 9da8f7b Compare

November 21, 2024 19:51


          abstract away the control-flow for applying args

3bd911e

pvdrz force-pushed the pvdrz/refactor-cli-arg-application branch from 9da8f7b to 3bd911e Compare

November 21, 2024 20:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet