Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak shell completion and --version without header #3040

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

heftig
Copy link
Contributor

@heftig heftig commented Dec 7, 2024

This regressed again in #2984. Partially revert d75fe27 and 42a86e2 and restore the previous behavior.

Fixes: #3037
Fixes: #3039

This regressed again in rust-lang#2984. Partially revert d75fe27 and
42a86e2 and restore the previous behavior.

Fixes: rust-lang#3037
Fixes: rust-lang#3039
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Dec 7, 2024
this is rust-lang/rust-bindgen#3040

this also unbreaks the mesa-asahi build
Copy link
Contributor

@pvdrz pvdrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added an extra commit with some regression tests so this doesn't happen again 👏

@pvdrz pvdrz enabled auto-merge December 8, 2024 15:36
@pvdrz pvdrz added this pull request to the merge queue Dec 8, 2024
Merged via the queue into rust-lang:main with commit 24045bc Dec 8, 2024
29 checks passed
bell-sw pushed a commit to bell-sw/alpaquita-aports that referenced this pull request Dec 9, 2024
[ commit ff261ebc9ab2b7c8ccb56f341e82697f16c3699b ]

this is rust-lang/rust-bindgen#3040

this also unbreaks the mesa-asahi build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bindgen --version does not work (0.71.0 regression) generate shell completion is changed in v0.71.0
2 participants