Skip to content

Fixes #890 #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2017
Merged

Fixes #890 #952

merged 2 commits into from
Nov 20, 2017

Conversation

outkaj
Copy link
Contributor

@outkaj outkaj commented Oct 30, 2017

How does this look as an improvement to the issue mentioned in #890? Thanks a lot!

@mark-i-m
Copy link
Contributor

Is the same true for crate_name? If so, it might be worth mentioning too.

@outkaj
Copy link
Contributor Author

outkaj commented Oct 31, 2017

It looks to me like the same is not true for crate_name, but could someone else confirm? Thanks for the question @mark-i-m

@steveklabnik
Copy link
Contributor

I believe it's true, yes. Would you mind adding it as well? :)

@outkaj
Copy link
Contributor Author

outkaj commented Oct 31, 2017

Not at all!

@steveklabnik
Copy link
Contributor

This is great, thanks! After travis is green, I'll merge. Should be fine :)

@steveklabnik steveklabnik merged commit 351a969 into rust-lang:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@steveklabnik steveklabnik steveklabnik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@outkaj @mark-i-m @steveklabnik