-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force full re-clippy #2604
Comments
I usually work around this by runnning something like |
can you try with clippy 0.0.203? I included a possible fix there |
I still have the issue with clippy 0.0.203 😢 |
Also seeing this with v0.0.204 |
cc @alexcrichton is there any way we can get a mode to cargo check that always rebuilds the toplevel crate (i.e. the root, or if running -p, that crate). Preferably not clobbering artefacts unless they need to be. |
@killercup is fixing the same bug that |
Memo to self (and promise to clippy maintainers) to actually expose this
somehow to non-cargo consumers!
…On Wed, 25 Jul 2018, 07:55 Dale Wijnand, ***@***.***> wrote:
@killercup <https://github.com/killercup> is fixing the same bug that cargo
fix has over in rust-lang/cargo#5750
<rust-lang/cargo#5750>, which I'm hopeful will
make fixing this much easier.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2604 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOXw4Lf8MmMPJ4yUwEYQs4DVlt7yRfks5uKAhTgaJpZM4TCq2v>
.
|
rust-lang/cargo#5944 was merged, which is a rebase of killercup's work. I'd be open to working on a fix for this, if there is anyone who can provide guidance on what is needed from the clippy side? |
If the cargo folks agree, perhaps we could have commandline arg in cargo which forces the package to be rebuilt. (cargo check -f / --force or something like that). We would somehow need to make sure it only forces recheck of the crates in the current workspace and not all dependencies as well, not sure what is the best way to do this though.. :/ |
Even something as simple as detecting that no work has been done and outputting a warning suggesting the user I believe the ideal solution is a diagnostic-caching mechanism, but currently users have no indication that |
I just submitted rust-lang/cargo#6664 to cargo to force |
It seems rust-lang/cargo#6664 is close to getting merged. It would be helpful if someone familiar with how clippy integrates with cargo could check in and confirm this would solve the clippy use case. |
Yes, but we may need to pass a flag down |
Encountered this problem - when i run clippy twice with different parameters, the program didn't get rebuilt, so i got no output. |
There's no need to retry clippy commands, they should be deterministic. Additionally re-using a container may cause us to get false positives due to rust-lang/rust-clippy#2604. This change should help us avoid that. Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
This is fixed on latest master of cargo for |
- adds a new 'clippy' category for exercises - clippy exercises should throw no warnings - install script now also installs clippy is related to rust-lang/rust-clippy#2604
Still an issue for me.
|
- adds a new 'clippy' category for exercises - clippy exercises should throw no warnings - install script now also installs clippy is related to rust-lang/rust-clippy#2604
- adds a new 'clippy' category for exercises - clippy exercises should throw no warnings - install script now also installs clippy is related to rust-lang/rust-clippy#2604
Turns out `name` is an Option and that `expr` can be a more complicated object rather than just a string. Previously we didn't have any tests that exercised the `expr` property. I think the issues with clippy are related to: rust-lang/rust-clippy#2604 fixes: #59
They don't seem to all come at once. This could be rust-lang/rust-clippy#2604 .
- adds a new 'clippy' category for exercises - clippy exercises should throw no warnings - install script now also installs clippy is related to rust-lang/rust-clippy#2604
- adds a new 'clippy' category for exercises - clippy exercises should throw no warnings - install script now also installs clippy is related to rust-lang/rust-clippy#2604
- adds a new 'clippy' category for exercises - clippy exercises should throw no warnings - install script now also installs clippy is related to rust-lang/rust-clippy#2604
I build clippy from git sources (4ef7238).
This is re-open of #2498 as @oli-obk suggested.
And actully nothing changes because of #2582 , and why it should?
Sample code:
As you use the second run of
clippy
gives nothing, andcargo clippy --help
have no options to force rerun.
The text was updated successfully, but these errors were encountered: