fix(parser): json index operator with alter table #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out `name` is an Option and that `expr` can be a more complicated object rather than just a string. Previously we didn't have any tests that exercised the `expr` property.
e.g.
```
error: this could be a `const fn`
367
--> cli/src/reporter.rs:375:1
368
|
369
375 | / fn get_violations_emoji(count: usize) -> &'static str {
370
376 | | if count > 0 {
371
377 | | "🚒"
372
378 | | } else {
373
379 | | "✅"
374
380 | | }
375
381 | | }
376
| |_^
377
|
378
= note: `-D clippy::missing-const-for-fn` implied by `-D clippy::nursery`
379
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn
```
kodiakhq
bot
deleted the
steve/fix-parsing-alter-table-with-json-index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
nameis an Option and thatexprcan be a more complicatedobject rather than just a string.
Previously we didn't have any tests that exercised the
exprproperty.I think the issues with clippy are related to: rust-lang/rust-clippy#2604
fixes: #59