-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): json index operator with alter table #61
Merged
kodiakhq
merged 8 commits into
master
from
steve/fix-parsing-alter-table-with-json-index
Sep 9, 2020
Merged
fix(parser): json index operator with alter table #61
kodiakhq
merged 8 commits into
master
from
steve/fix-parsing-alter-table-with-json-index
Sep 9, 2020
Commits on Sep 8, 2020
-
fix(parser): json index operator with alter table
Turns out `name` is an Option and that `expr` can be a more complicated object rather than just a string. Previously we didn't have any tests that exercised the `expr` property.
Configuration menu - View commit details
-
Copy full SHA for 4ea6312 - Browse repository at this point
Copy the full SHA 4ea6312View commit details -
don't use nursery since it will update with WIP lints
e.g. ``` error: this could be a `const fn` 367 --> cli/src/reporter.rs:375:1 368 | 369 375 | / fn get_violations_emoji(count: usize) -> &'static str { 370 376 | | if count > 0 { 371 377 | | "🚒" 372 378 | | } else { 373 379 | | "✅" 374 380 | | } 375 381 | | } 376 | |_^ 377 | 378 = note: `-D clippy::missing-const-for-fn` implied by `-D clippy::nursery` 379 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn ```
Configuration menu - View commit details
-
Copy full SHA for 0941e76 - Browse repository at this point
Copy the full SHA 0941e76View commit details
Commits on Sep 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c69ed86 - Browse repository at this point
Copy the full SHA c69ed86View commit details -
Configuration menu - View commit details
-
Copy full SHA for b47f9ef - Browse repository at this point
Copy the full SHA b47f9efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7112e71 - Browse repository at this point
Copy the full SHA 7112e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1864d4 - Browse repository at this point
Copy the full SHA d1864d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b7fb98 - Browse repository at this point
Copy the full SHA 7b7fb98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be936b - Browse repository at this point
Copy the full SHA 3be936bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.