Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use span_suggestion instead of manually building suggestions #442

Closed
Manishearth opened this issue Nov 7, 2015 · 2 comments
Closed

Use span_suggestion instead of manually building suggestions #442

Manishearth opened this issue Nov 7, 2015 · 2 comments

Comments

@Manishearth
Copy link
Member

http://manishearth.github.io/rust-internals-docs/rustc/session/struct.Session.html#method.span_suggestion

See, for example, the suggestion you get for http://is.gd/5k86CL, it's built by running span_suggestion with format!("move {}", snippet_for_closure).
@sanxiyn
Copy link
Member

sanxiyn commented Dec 7, 2015

Manishearth/compiletest-rs#30 is merged. Waiting on the new version to update dependency.

This was referenced Dec 8, 2015
Merged
Merged
@Manishearth Manishearth mentioned this issue Dec 23, 2015
Merged
mcarton added a commit to mcarton/rust-clippy that referenced this issue Jan 13, 2016
@mcarton
Use span_suggestion in matches lints
76877d3 
Ref rust-lang#442
mcarton added a commit to mcarton/rust-clippy that referenced this issue Jan 13, 2016
@mcarton
Use span_suggestion in matches lints
44daa8b 
Ref rust-lang#442
@mcarton mcarton mentioned this issue Feb 7, 2016
Merged
@mcarton mcarton mentioned this issue Feb 24, 2016
Merged
This was referenced Mar 9, 2016
Merged
Merged
@oli-obk
Copy link
Contributor

oli-obk commented May 10, 2017

I think we're doing this everywhere now.

@oli-obk oli-obk closed this as completed May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanxiyn @oli-obk @Manishearth