Use suggestion for needless_return #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "unneeded return statement. Consider using `{}` \ | ||
| without the return and trailing semicolon", | ||
| snippet(cx, spans.1, ".."))) | ||
| span_lint_and_then(cx, NEEDLESS_RETURN, spans.0, |
There was a problem hiding this comment.
What if the snippet is None?
There was a problem hiding this comment.
Previously, we said "Consider using ..", which is nonsense. Now we say "unneeded return statement", without a suggestion.
There was a problem hiding this comment.
Fine, but we could do even better by defaulting to a suggestion to remove the return and semicolon.
There was a problem hiding this comment.
Well, maybe later.
I note that currently we say "without trailing semicolon" even when there is no trailing semicolon. I don't think the current message is very good.
Manishearth
added a commit
that referenced
this pull request
Dec 17, 2015
Use suggestion for needless_return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #442.
Instead of saying "without trailing semicolon", show the replacement without trailing semicolon.