-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: manual_memcpy wrong indexing for multi dimensional arrays
#12010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: manual_memcpy wrong indexing for multi dimensional arrays
#12010
Conversation
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
0337145 to
7de5fbe
Compare
manual_memcpy wrong indexing for multi dimensional arrays
|
☔ The latest upstream changes (presumably #12198) made this pull request unmergeable. Please resolve the merge conflicts. |
7de5fbe to
be3c03a
Compare
|
Hi @Alexendoo , this is just a friendly reminder about this PR. |
|
☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts. |
be3c03a to
4c6fe61
Compare
bc5b8a3 to
71e9451
Compare
chore: rebase master chore: replace $DIR fix: check bases does not contain reference to loop index fix: grammatical mistake fix: style
0776bc5 to
dfedadc
Compare
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes: #9334
This PR fixes an invalid suggestion for multi-dimensional arrays.
For example,
For the above code, Clippy suggests
dst.copy_from_slice(&src[i]);, but it is not compilable becauseiis only used to loop the array.I adjusted it so that Clippy
manual_memcpyworks properly for multi-dimensional arrays.changelog: [
manual_memcpy]: Fixes invalid indexing suggestions for multi-dimensional arrays