Remove $DIR replacement

[Alexendoo]

This won't cause problems because the old $DIR replacement was based on the parent of the test path, which for us is relative:

rust-clippy/tests/compile-test.rs

Line 122 in 5471e06

..Config::rustc(Path::new("tests").join(test_dir))

The new pattern being "tests/{test_dir}" is more clearly relative

That's why we have custom filters applied to the toml/cargo tests where absolute paths do appear in the output

rust-clippy/tests/compile-test.rs

Lines 198 to 202 in 5471e06

	config
	.comment_defaults
	.base()
	.normalize_stderr
	.push((Match::from(env::current_dir().unwrap().as_path()), b"$DIR".into()));

Removing it allows clicking the paths in the terminal

changelog: none

r? @flip1995

[flip1995]

@bors r+ p=10

Thanks!

[bors]

📌 Commit 740d89e has been approved by flip1995

It is now in the queue for this repository.

[bors]

⌛ Testing commit 740d89e with merge 74f611f...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 74f611f to master...