bool_comparison: no longer lint on !x != y
#15498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
added
S-blocked
ada4a
force-pushed
the
bool-comparison
branch
2 times, most recently
from
0664c16 to
ea79f2a
Compare
This comment has been minimized.
This comment has been minimized.
|
@rustbot ready |
rustbot
added
S-waiting-on-review
ada4a
force-pushed
the
bool-comparison
branch
3 times, most recently
from
9d47638 to
194aa0b
Compare
misc: rm "as shown" from help message - clippy guidelines recommend against this
misc: pull conditions into let-chain
misc: use `Span::to`
misc: inline `{l,r}_ty`
misc: move the type checks out of `check_comparison`
misc: make test cases much less verbose
samueltardieu
approved these changes
Aug 22, 2025
rustbot
removed
the
S-waiting-on-review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2025
For some reason I don't really understand, this lint was mushed together with `needless_bool(_assign)`, even though they seemingly didn't have a lot of overlapping logic -- for one, their lint passes are separate, and can't be merged in a meaningful way. I first wanted to move the file under `booleans/` and move the common logic into `utils.rs`, and then split the files, but it turns out that the entirety of common logic was the `fetch_bool_expr` function, which is literally just `expr.as_literal()?.as_bool()`. So I scratched that idea, moved `bool_comparison` logic to a new file, and copy-pasted the function into it. I think this change is advantageous in two main ways: 1. no confusing intermingling of two different passes' logics 2. the file that defines `clippy::bool_comparison` becomes easier to find, because now there's a file with that name. This PR depends on #15498, but only for easier-rebase purposes. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue that this PR was opened to fix (#15367), talked about how, for
!x == false, this lint suggests both:x != falsexI initially wanted to make the lint short-circuit after emitting the first suggestion (since that was the easier change code-wise), but that was not optimal for two reasons:
nonminimal_boolAnd so I instead decided to completely remove the code path that emits suggestion 1.
Fixes #15367
changelog: [
bool_comparison]: no longer lint on!x != y