Skip to content

bool_comparison: fix incorrect suggestion with >/< and macros #15513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

bool_comparison: fix incorrect suggestion with >/< and macros #15513

merged 1 commit into from
Aug 22, 2025

Conversation

notriddle
Copy link
Contributor

Fixes #15497

changelog: [bool_comparison]: fix incorrect suggestion with >/< and macros

@rustbot
Copy link
Collaborator

rustbot commented Aug 19, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 19, 2025
ada4a
ada4a reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@ada4a ada4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! I've got one question, but LGTM otherwise

@notriddle
Copy link
Contributor Author

notriddle commented Aug 19, 2025 •
edited
Loading

You're right. Both of those changes are fine.

samueltardieu
samueltardieu requested changes Aug 22, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM. Could you squash the commits?

r? samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned Jarcho Aug 22, 2025
This was referenced Aug 22, 2025
Merged
Merged
@notriddle notriddle force-pushed the macro-invocation-bool-comparison branch from d2b0da6 to 7697b61 Compare August 22, 2025 19:01
@notriddle
Copy link
Contributor Author

Okay, they're squashed.

@samueltardieu samueltardieu added this pull request to the merge queue Aug 22, 2025
Merged via the queue into rust-lang:master with commit df0499a Aug 22, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2025
@notriddle notriddle deleted the macro-invocation-bool-comparison branch August 22, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 left review comments

@samueltardieu samueltardieu samueltardieu approved these changes

+1 more reviewer

@ada4a ada4a ada4a left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@samueltardieu samueltardieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bool_comparison mangles macro invocations
6 participants
@notriddle @rustbot @samueltardieu @y21 @ada4a @Jarcho