-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rustfmt running on AppVeyor for now #4617
Conversation
rustfmt doesn't seem to execute correctly right now, causing some backlog of PRs. It's not critical that it runs on Windows, so I've disabled it for now.
@bors r+ |
📌 Commit 0703ec8 has been approved by |
Disable rustfmt running on AppVeyor for now rustfmt doesn't seem to execute correctly right now, causing some backlog of PRs. It's not critical that it runs on Windows, so I've disabled it for now.
💔 Test failed - checks-travis |
The reason CI is failing is because |
@bors r=@Manishearth retry |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 0703ec8 has been approved by |
Disable rustfmt running on AppVeyor for now rustfmt doesn't seem to execute correctly right now, causing some backlog of PRs. It's not critical that it runs on Windows, so I've disabled it for now. changelog: none
@bors retry |
@mikerite Cargo path LGTM:
|
Disable rustfmt running on AppVeyor for now rustfmt doesn't seem to execute correctly right now, causing some backlog of PRs. It's not critical that it runs on Windows, so I've disabled it for now. changelog: none
This was missing the 'changelog' line. |
Do we ever need to run rustfmt on Windows? IIRC rustfmt works consistent on all platforms. |
I think even if there were differences, we won't likely care about them. This is clippy's CI, not rustfmt's. |
💔 Test failed - status-appveyor |
If a Windows user ever wanted to contribute it would be nice if they could run the rustfmt test. There is little chance of that if we can't even get it working on CI. |
The problem appears to be with rustup, not rustfmt. |
|
Too tired. Ignore my last few posts. |
FYI it has been reported upstream rust-lang/cargo#7475 |
rustfmt doesn't seem to execute correctly right now, causing some
backlog of PRs. It's not critical that it runs on Windows, so I've
disabled it for now.
changelog: none