try go fix cargo fmt invocation #4620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors try |
bors
added a commit
that referenced
this pull request
Oct 3, 2019
try go fix cargo fmt invocation changelog: none
|
💔 Test failed - status-appveyor |
|
Hm, apparently |
tesuji
reviewed
Oct 3, 2019
| @@ -1,3 +1,4 @@ | |||
| use home; | |||
There was a problem hiding this comment.
We don't need this in 2018 edition
Suggested change
| use home; |
tesuji
reviewed
Oct 3, 2019
| // because we will end up with cargo --foo +nightly fmt but the "+nightly" needs to come first | ||
| // get the absolute path to the cargo binary inside $CARGO_HOME | ||
| let cargo_home = home::cargo_home().expect("failed to get cargo home path!"); | ||
| let cargo_path = cargo_home.join("bin").join("cargo"); |
There was a problem hiding this comment.
Suggested change
| let cargo_path = cargo_home.join("bin").join("cargo"); | |
| let cargo_path = cargo_home.join("bin").join(format!("cargo{}", std::env::consts::EXE_SUFFIX)); |
|
The issue turned out to be a cargo bug: rust-lang/cargo#7475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use absolute path $CARGO_HOME/bin/cargo to get cargo path in rustfmt tests.
I get the same error as this is supposed to fix on my system because I have an alias
cargo="cargo --fooon my system.This causes
cargo +nightly checkto be resolved tocargo --foo +nightly checkwhich is wrong because the+nightlyneeds to be the first arg!Work around by circumventing possible aliasing and using the absolute path to the cargo binary.
changelog: none