-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade match_wild_err_arm
to pedantic and update help messages
#5622
Conversation
98a0d1d
to
9ff599f
Compare
Thanks! We currently looking in pinning a nightly. @bors r+ |
📌 Commit 9ff599f has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #5582) made this pull request unmergeable. Please resolve the merge conflicts. |
9ff599f
to
2db7f1a
Compare
@flip1995 Thanks! |
@bors r+ Thanks! |
📌 Commit 2db7f1a has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Hi,
This fixes #3688 and downgrades
match_wild_err_arm
to pedantic.There are a lot of different reasons in that issue, for me the biggest are:
track_caller
feature got introduced it was actually easier to track the panic location with explicitpanic!
than withexpect
.Currently clippy is failing to build because of a breaking change in rust-lang/rust#69171 I tried fixing it but it is too complex for my little knowledge of clippy and rustc so I'll leave that to people who know what they're doing :)
Another thing, if rustc is breaking clippy a lot then maybe it's better to use something like
miri
does, where it's hard codes the latest tested rustc commit and they keep bumping it, that way when you develop locally it should work even if there was a breaking change (https://github.com/rust-lang/miri/blob/master/rustup-toolchain#L23-L29)changelog: Downgrade
match_wild_err_arm
to pedantic