-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor types lints #6725
Refactor types lints #6725
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Changes: Import declared lint at the top of the file instead of using it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat! LGTM ♻️
☔ The latest upstream changes (presumably #6789) made this pull request unmergeable. Please resolve the merge conflicts. |
713aab1
to
caeaa60
Compare
☔ The latest upstream changes (presumably #6601) made this pull request unmergeable. Please resolve the merge conflicts. |
caeaa60
to
9de9319
Compare
Changes: Resolve conflicts. |
☔ The latest upstream changes (presumably #6823) made this pull request unmergeable. Please resolve the merge conflicts. |
Argh, this conflict needs much work to resolve. @flip1995 Please notify me when you are ready to review this, I don't want to rebase this again and again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-rebased changes LGTM. Ping me, if you get to rebasing this and I can quickly review the rebase.
9de9319
to
db59c35
Compare
@flip1995 Thanks for your review! I've finished the rebase. |
Thanks! As promised: @bors r+ p=3 |
📌 Commit db59c35 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Ref #6724.
As described in #6724,
types.rs
contains many groups inside it.In this PR, I reorganize the lints of the
types
group into their own modules.changelog: none