Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor types lints #6725

Merged
merged 12 commits into from
Mar 8, 2021
Merged

Refactor types lints #6725

merged 12 commits into from
Mar 8, 2021

Conversation

Y-Nak
Copy link
Contributor

@Y-Nak Y-Nak commented Feb 12, 2021

Ref #6724.
As described in #6724, types.rs contains many groups inside it.
In this PR, I reorganize the lints of the types group into their own modules.

changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2021
@Y-Nak
Copy link
Contributor Author

Y-Nak commented Feb 16, 2021

Changes: Import declared lint at the top of the file instead of using it with super:: prefix in the implementation. See this review.

Copy link
Contributor

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@nahuakang nahuakang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat! LGTM ♻️

@bors
Copy link
Contributor

bors commented Feb 25, 2021

☔ The latest upstream changes (presumably #6789) made this pull request unmergeable. Please resolve the merge conflicts.

@Y-Nak Y-Nak force-pushed the refactor-types-lints branch from 713aab1 to caeaa60 Compare February 25, 2021 16:07
@bors
Copy link
Contributor

bors commented Feb 25, 2021

☔ The latest upstream changes (presumably #6601) made this pull request unmergeable. Please resolve the merge conflicts.

@Y-Nak Y-Nak force-pushed the refactor-types-lints branch from caeaa60 to 9de9319 Compare March 2, 2021 10:15
@Y-Nak
Copy link
Contributor Author

Y-Nak commented Mar 2, 2021

Changes: Resolve conflicts.

@bors
Copy link
Contributor

bors commented Mar 7, 2021

☔ The latest upstream changes (presumably #6823) made this pull request unmergeable. Please resolve the merge conflicts.

@Y-Nak
Copy link
Contributor Author

Y-Nak commented Mar 7, 2021

Argh, this conflict needs much work to resolve.

@flip1995 Please notify me when you are ready to review this, I don't want to rebase this again and again.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-rebased changes LGTM. Ping me, if you get to rebasing this and I can quickly review the rebase.

@Y-Nak Y-Nak force-pushed the refactor-types-lints branch from 9de9319 to db59c35 Compare March 8, 2021 15:53
@Y-Nak
Copy link
Contributor Author

Y-Nak commented Mar 8, 2021

@flip1995 Thanks for your review! I've finished the rebase.

@flip1995
Copy link
Member

flip1995 commented Mar 8, 2021

Thanks!

As promised:

@bors r+ p=3

@bors
Copy link
Contributor

bors commented Mar 8, 2021

📌 Commit db59c35 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Mar 8, 2021

⌛ Testing commit db59c35 with merge b207f23...

@bors
Copy link
Contributor

bors commented Mar 8, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing b207f23 to master...

@bors bors merged commit b207f23 into rust-lang:master Mar 8, 2021
@Y-Nak Y-Nak deleted the refactor-types-lints branch March 8, 2021 16:18
@bors bors mentioned this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants