Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for refactoring types.rs #6724

Closed
4 tasks done
Y-Nak opened this issue Feb 12, 2021 · 3 comments · Fixed by #6938
Closed
4 tasks done

Tracking Issue for refactoring types.rs #6724

Y-Nak opened this issue Feb 12, 2021 · 3 comments · Fixed by #6938
Labels
C-tracking-issue Category: Tracking Issue

Comments

@Y-Nak
Copy link
Contributor

Y-Nak commented Feb 12, 2021 •
edited by flip1995
Loading

While refactoring types.rs in #6680, I found that types.rs contains not only the types group but also other groups like the cast group.
This issue is a tracking issue for refactoring types.rs to avoid a too large PR and split them into small PRs.

  • types group(Refactor types lints #6725):
    • BOX_VEC
    • VEC_BOX
    • OPTION_OPTION
    • LINKEDLIST
    • BORROWED_BOX
    • REDUNDANT_ALLOCATION
    • RC_BUFFER
  • casts group(Refactor casts lint #6873):
    • CAST_PRECISION_LOSS
    • CAST_SIGN_LOSS
    • CAST_POSSIBLE_TRUNCATION
    • CAST_POSSIBLE_WRAP
    • CAST_LOSSLESS
    • UNNECESSARY_CAST
    • CAST_PTR_ALIGNMENT
    • FN_TO_NUMERIC_CAST
    • FN_TO_NUMERIC_CAST_WITH_TRUNCATION
    • CHAR_LIT_AS_U8
    • CAST_REF_TO_MUT
    • PTR_AS_PTR
  • unit_type group (Refactor unit types #6889):
    • LET_UNIT_VALUE
    • UNIT_CMP
    • UNIT_ARG
  • another:
    • ABSURD_EXTREME_COMPARISONS
    • INVALID_UPCAST_COMPARISONS
    • IMPLICIT_HASHER
    • TYPE_COMPLEXITY: I think this lint should be grouped into types but the implementation of LateLintPass seems slightly different from that of Types. needs further discussion.
@Y-Nak

This comment has been minimized.

Sign in to view
@rustbot rustbot added C-tracking-issue Category: Tracking Issue I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied labels Feb 12, 2021
@Y-Nak

This comment has been minimized.

Sign in to view
@rustbot rustbot removed the I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied label Feb 12, 2021
@Y-Nak Y-Nak mentioned this issue Feb 12, 2021
Merged
@magurotuna magurotuna mentioned this issue Feb 12, 2021
Open
8 tasks
@flip1995
Copy link
Member

+1 for splitting that module up further.

bors added a commit that referenced this issue Mar 8, 2021
@bors
Auto merge of #6725 - Y-Nak:refactor-types-lints, r=flip1995
b207f23 
Refactor types lints

Ref #6724.
As described in #6724, `types.rs` contains many groups inside it.
In this PR, I reorganize the lints of the `types` group into their own modules.

changelog: none
@Y-Nak Y-Nak mentioned this issue Mar 9, 2021
Merged
bors added a commit that referenced this issue Mar 9, 2021
@bors
Auto merge of #6873 - Y-Nak:refactor-casts-lint, r=flip1995
3ed0bcc 
Refactor casts lint

Ref: #6724

Changes:
1. Separate the `casts` group from the `types` group.
2. Reorganize the lints of the `casts` group into their own modules.

Notes:
1. I didn't `fix` #6874 in order to maintain this PR as small as possible.

---
changelog: none
@Y-Nak Y-Nak mentioned this issue Mar 12, 2021
Merged
bors added a commit that referenced this issue Mar 16, 2021
@bors
Auto merge of #6889 - Y-Nak:refactor-unit-types, r=Y-Nak
59cf93a 
Refactor unit types

Ref:  #6724
r? `@flip1995`

Changes:
1. Extract `unit_types` from `types` group.
2. Move lints of `unit_types` to their own modules.

Notes:
Other lints of `unit_types` is still scattered around the `clippy_lints`, e.g. `result_unit_err` or `option_map_unit_fn`.
These should be addressed in another PR.

changelog: none
bors added a commit that referenced this issue Mar 16, 2021
@bors
Auto merge of #6889 - Y-Nak:refactor-unit-types, r=flip1995
81c0154 
Refactor unit types

Ref:  #6724
r? `@flip1995`

Changes:
1. Extract `unit_types` from `types` group.
2. Move lints of `unit_types` to their own modules.

Notes:
Other lints of `unit_types` is still scattered around the `clippy_lints`, e.g. `result_unit_err` or `option_map_unit_fn`.
These should be addressed in another PR.

changelog: none
bors added a commit that referenced this issue Mar 16, 2021
@bors
Auto merge of #6889 - Y-Nak:refactor-unit-types, r=flip1995
c701c30 
Refactor unit types

Ref:  #6724
r? `@flip1995`

Changes:
1. Extract `unit_types` from `types` group.
2. Move lints of `unit_types` to their own modules.

Notes:
Other lints of `unit_types` is still scattered around the `clippy_lints`, e.g. `result_unit_err` or `option_map_unit_fn`.
These should be addressed in another PR.

changelog: none
@Y-Nak Y-Nak mentioned this issue Mar 20, 2021
Merged
@bors bors closed this as completed in 2e33bf6 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: Tracking Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor types Y-Nak/rust-clippy
3 participants
@Y-Nak @flip1995 @rustbot