Refactor casts lint #6873
Merged
Refactor casts lint #6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
4 tasks
Y-Nak
force-pushed
the
refactor-casts-lint
branch
from
1645295 to
9e631da
Compare
flip1995
approved these changes
Mar 9, 2021
Comment on lines
+12
to
+15
| match cast_to.kind() { | ||
| ty::Uint(_) | ty::Int(..) => { /* continue on */ }, | ||
| _ => return, | ||
| } |
There was a problem hiding this comment.
It would be nice to go over the code and do some clean up. As an example: This would be nicer to do with
if !matches!(cast_to.kind(), ty::Uint(_) | ty::Int(..)) {
return;
}But this shouldn't be done in this PR.
|
@bors r+ p=1 |
|
📌 Commit 9e631da has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6724
Changes:
castsgroup from thetypesgroup.castsgroup into their own modules.Notes:
fixUsespan_lint_and_sugginstead ofspan_lintinunnecessary_cast#6874 in order to maintain this PR as small as possible.changelog: none