Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use span_lint_and_sugg instead of span_lint in unnecessary_cast #6874

Closed
Y-Nak opened this issue Mar 9, 2021 · 1 comment · Fixed by #6895
Closed

Use span_lint_and_sugg instead of span_lint in unnecessary_cast #6874

Y-Nak opened this issue Mar 9, 2021 · 1 comment · Fixed by #6895
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy

Comments

@Y-Nak
Copy link
Contributor

Y-Nak commented Mar 9, 2021 •
edited
Loading

The lines below should be replaced by span_lint_and_sugg or lint_unnecessary_cast as another part of unnecessary_cast does.

rust-clippy/clippy_lints/src/casts/unnecessary_cast.rs

Lines 49 to 57 in 3ed0bcc

span_lint(
cx,
UNNECESSARY_CAST,
expr.span,
&format!(
"casting to the same type is unnecessary (`{}` -> `{}`)",
cast_from, cast_to
),
);

@Y-Nak

This comment has been minimized.

Sign in to view
@rustbot rustbot added C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy labels Mar 9, 2021
@Y-Nak Y-Nak changed the title Use span_and_sugg in unnecessary_cast instead of span_lint Use span_and_sugg instead of span_lint in unnecessary_cast Mar 9, 2021
@Y-Nak Y-Nak changed the title Use span_and_sugg instead of span_lint in unnecessary_cast Use span_lint_and_sugg instead of span_lint in unnecessary_cast Mar 9, 2021
@Y-Nak Y-Nak mentioned this issue Mar 9, 2021
Merged
bors added a commit that referenced this issue Mar 9, 2021
@bors
Auto merge of #6873 - Y-Nak:refactor-casts-lint, r=flip1995
3ed0bcc 
Refactor casts lint

Ref: #6724

Changes:
1. Separate the `casts` group from the `types` group.
2. Reorganize the lints of the `casts` group into their own modules.

Notes:
1. I didn't `fix` #6874 in order to maintain this PR as small as possible.

---
changelog: none
@iobtl iobtl mentioned this issue Mar 13, 2021
Merged
@bors bors closed this as completed in 52c25e9 Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace span_lint with span_lint_and_sugg along with error message iobtl/rust-clippy
2 participants
@Y-Nak @rustbot