Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workspace at once #6749

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Test workspace at once #6749

merged 2 commits into from
Feb 16, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: none

Follow-up to #6733

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 16, 2021
@Manishearth
Copy link
Member

@bors r+

neat

@bors
Copy link
Contributor

bors commented Feb 16, 2021

📌 Commit e355652 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Feb 16, 2021

⌛ Testing commit e355652 with merge 877be18...

@Manishearth
Copy link
Member

This doesn't break the rustc workspace, does it? cc @flip1995

@camsteffen
Copy link
Contributor Author

Oh I meant to merge this after #6733 since that change is also here. I don't know about the rustc workspace.

@bors
Copy link
Contributor

bors commented Feb 16, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 877be18 to master...

@bors bors merged commit 877be18 into rust-lang:master Feb 16, 2021
@flip1995
Copy link
Member

This doesn't break the rustc workspace, does it?

Don't know. rustc is itself a workspace with Clippy being a member of that. I'm not sure if a workspace in a workspace may cause problems. But I can test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants