Lintcheck and an options for command line options

[flip1995]

Make it possible to add command line options to the clippy invocation of the lintcheck-tool

changelog: none

r? @matthiaskrgr

I found that this will be really helpful if we use a separate repository and want to maintain a all-lints-passing list of crates. See my early experimentation here: https://github.com/flip1995/clippy-lintcheck

git submodule update --init
cargo run -- --mode=all

Will run the lintcheck tool on all the specified crates in config/ in that repository.

[matthiaskrgr]

Thanks!
@bors r+

[bors]

📌 Commit 79d7f4c has been approved by matthiaskrgr

[bors]

⌛ Testing commit 79d7f4c with merge ddeea97...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing ddeea97 to master...

[matthiaskrgr]

Hmm, I think this broke something :(
It seems that only -git source-results are stored in the log now for some reason.

[flip1995]

Huh, it worked for me locally. Can you try to delete the target/lintcheck/shared_something_somethin and check if it is a caching issue?

[matthiaskrgr]

The problem is, when I run /home/matthias/vcs/github/rust-clippy/target/debug/cargo-clippy on ~/vcs/github/rust-clippy/target/lintcheck/crates/xsv-0.13.0, I get

current:   /home/matthias/vcs/github/rust-clippy/target/lintcheck/crates/xsv-0.13.0/Cargo.toml
workspace: /home/matthias/vcs/github/rust-clippy/Cargo.toml

this may be fixable by ensuring that this crate is depended on by the workspace root: /home/matthias/vcs/github/rust-clippy/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.

🤔

[matthiaskrgr]

CC #6749 ?

[flip1995]

Oh yeah, that is #6749

[matthiaskrgr]

Adding the target directory to workspace.exlude does not seem to work because the path is expected to point at a specific crate, mh...

[flip1995]

Maybe let the lintcheck tool add the crates to Cargo.toml, run the check and remove them again? But that seems way to hacky.